Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-6471

RocksDBStateBackendTest#testCancelRunningSnapshot sometimes fails

    Details

    • Type: Test
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.3.0
    • Component/s: None
    • Labels:
      None

      Description

      I got the following test failure based on commit f37988c19adc30d324cde83c54f2fa5d36efb9e7 :

      testCancelRunningSnapshot[1](org.apache.flink.contrib.streaming.state.RocksDBStateBackendTest)  Time elapsed: 0.166 sec  <<< FAILURE!
      java.lang.AssertionError: null
        at org.junit.Assert.fail(Assert.java:86)
        at org.junit.Assert.assertTrue(Assert.java:41)
        at org.junit.Assert.assertTrue(Assert.java:52)
        at org.apache.flink.contrib.streaming.state.RocksDBStateBackendTest.testCancelRunningSnapshot(RocksDBStateBackendTest.java:313)
      
      
      Results :
      
      Failed tests:
        RocksDBStateBackendTest.testCancelRunningSnapshot:313 null
      

      The following assertion fails:

          assertTrue(testStreamFactory.getLastCreatedStream().isClosed());
      

        Issue Links

          Activity

          Hide
          yuzhihong@gmail.com Ted Yu added a comment -

          Running RocksDBStateBackendTest under flink-contrib/flink-statebackend-rocksdb passes.

          Show
          yuzhihong@gmail.com Ted Yu added a comment - Running RocksDBStateBackendTest under flink-contrib/flink-statebackend-rocksdb passes.
          Hide
          srichter Stefan Richter added a comment -

          Thanks for reporting this problem.

          This is cause by a problem that I fixed in `BlockerCheckpointStreamFactory`. However, it seems like for unknown reason (probably a move refactoring + merge) this class existed twice, with all duplicated code. I will delete the copy and just use the one, correct implementation everywhere.

          Show
          srichter Stefan Richter added a comment - Thanks for reporting this problem. This is cause by a problem that I fixed in `BlockerCheckpointStreamFactory`. However, it seems like for unknown reason (probably a move refactoring + merge) this class existed twice, with all duplicated code. I will delete the copy and just use the one, correct implementation everywhere.
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user StefanRRichter opened a pull request:

          https://github.com/apache/flink/pull/3837

          FLINK-6471 [checkpoint] Fix RocksDBStateBackendTest

          `RocksDBStateBackendTest::testCancelRunningSnapshot` sometimes failes. This is cause by a problem that I fixed in `BlockerCheckpointStreamFactory`.

          However, it seems like for unknown reason (probably a move refactoring + merge) this class existed twice, with all duplicated code. This PR deletes the copy and uses the one correct implementation everywhere.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/StefanRRichter/flink FLINK-6471

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/flink/pull/3837.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #3837



          Show
          githubbot ASF GitHub Bot added a comment - GitHub user StefanRRichter opened a pull request: https://github.com/apache/flink/pull/3837 FLINK-6471 [checkpoint] Fix RocksDBStateBackendTest `RocksDBStateBackendTest::testCancelRunningSnapshot` sometimes failes. This is cause by a problem that I fixed in `BlockerCheckpointStreamFactory`. However, it seems like for unknown reason (probably a move refactoring + merge) this class existed twice, with all duplicated code. This PR deletes the copy and uses the one correct implementation everywhere. You can merge this pull request into a Git repository by running: $ git pull https://github.com/StefanRRichter/flink FLINK-6471 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/3837.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3837
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user tedyu commented on the issue:

          https://github.com/apache/flink/pull/3837

          lgtm

          Show
          githubbot ASF GitHub Bot added a comment - Github user tedyu commented on the issue: https://github.com/apache/flink/pull/3837 lgtm
          Hide
          srichter Stefan Richter added a comment -

          Fixed in b8ffacb1b8.

          Show
          srichter Stefan Richter added a comment - Fixed in b8ffacb1b8.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user StefanRRichter commented on the issue:

          https://github.com/apache/flink/pull/3837

          Merged.

          Show
          githubbot ASF GitHub Bot added a comment - Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/3837 Merged.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user StefanRRichter closed the pull request at:

          https://github.com/apache/flink/pull/3837

          Show
          githubbot ASF GitHub Bot added a comment - Github user StefanRRichter closed the pull request at: https://github.com/apache/flink/pull/3837

            People

            • Assignee:
              srichter Stefan Richter
              Reporter:
              yuzhihong@gmail.com Ted Yu
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development