Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-6411

YarnApplicationMasterRunner should not interfere with RunningJobsRegistry

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.3.0
    • Fix Version/s: 1.3.0
    • Labels:
      None

      Description

      The YarnApplicationMasterRunner removes the running job from the RunningJobsRegistry when it is shut down. This should not be its responsibility and rather be delegated to the JobManagerRunner.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user tillrohrmann opened a pull request:

          https://github.com/apache/flink/pull/3797

          FLINK-6411 [flip-6] Remove job removal from RunningJobsRegistry in YarnFlinkApplicationMasterRunner.shutdown

          The YarnFlinkApplicationMasterRunner should not be concerned with removing jobs from
          the RunningJobsRegistry. This is the responsibility of the JobManagerRunner.

          This PR removes the job removal from the RunningJobRegistry from the
          YarnFlinkApplicationMasterRunner.shutdown method.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/tillrohrmann/flink FLINK-6411

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/flink/pull/3797.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #3797


          commit 6dca3b8308ebd703b7f98da4780c9180184a4af4
          Author: Till Rohrmann <trohrmann@apache.org>
          Date: 2017-04-28T10:17:42Z

          FLINK-6411 [flip-6] Remove job removal from RunningJobsRegistry in YarnFlinkApplicationMasterRunner.shutdown

          The YarnFlinkApplicationMasterRunner should not be concerned with removing jobs from
          the RunningJobsRegistry. This is the responsibility of the JobManagerRunner.

          This PR removes the job removal from the RunningJobRegistry from the
          YarnFlinkApplicationMasterRunner.shutdown method.


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/3797 FLINK-6411 [flip-6] Remove job removal from RunningJobsRegistry in YarnFlinkApplicationMasterRunner.shutdown The YarnFlinkApplicationMasterRunner should not be concerned with removing jobs from the RunningJobsRegistry. This is the responsibility of the JobManagerRunner. This PR removes the job removal from the RunningJobRegistry from the YarnFlinkApplicationMasterRunner.shutdown method. You can merge this pull request into a Git repository by running: $ git pull https://github.com/tillrohrmann/flink FLINK-6411 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/3797.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3797 commit 6dca3b8308ebd703b7f98da4780c9180184a4af4 Author: Till Rohrmann <trohrmann@apache.org> Date: 2017-04-28T10:17:42Z FLINK-6411 [flip-6] Remove job removal from RunningJobsRegistry in YarnFlinkApplicationMasterRunner.shutdown The YarnFlinkApplicationMasterRunner should not be concerned with removing jobs from the RunningJobsRegistry. This is the responsibility of the JobManagerRunner. This PR removes the job removal from the RunningJobRegistry from the YarnFlinkApplicationMasterRunner.shutdown method.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user tillrohrmann commented on the issue:

          https://github.com/apache/flink/pull/3797

          Merging this PR since changes are trivial and Travis gave green light.

          Show
          githubbot ASF GitHub Bot added a comment - Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/3797 Merging this PR since changes are trivial and Travis gave green light.
          Hide
          till.rohrmann Till Rohrmann added a comment -

          Fixed via c36d6b808285961505d39187408e1bf77b7b5ea1

          Show
          till.rohrmann Till Rohrmann added a comment - Fixed via c36d6b808285961505d39187408e1bf77b7b5ea1
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/flink/pull/3797

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3797

            People

            • Assignee:
              till.rohrmann Till Rohrmann
              Reporter:
              till.rohrmann Till Rohrmann
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development