Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-6409

TUMBLE/HOP/SESSION_START/END do not resolve time field correctly

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.3.0
    • Component/s: Table API & SQL
    • Labels:
      None

      Description

      Calcite has a bug and cannot resolve the time fields of auxiliary group functions correctly. A discussion can be found in CALCITE-1761.

      Right now this issue only affects our batch SQL API, but it is a blocker for FLINK-5884.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/flink/pull/3799

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3799
          Hide
          twalthr Timo Walther added a comment -

          Fixed in 1.3.0: 2d33c0bead3f13417acff0f18f78a5c2c5bef22e

          Show
          twalthr Timo Walther added a comment - Fixed in 1.3.0: 2d33c0bead3f13417acff0f18f78a5c2c5bef22e
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user twalthr commented on the issue:

          https://github.com/apache/flink/pull/3799

          Thanks @fhueske. I will merge this and create a JIRA for it

          Show
          githubbot ASF GitHub Bot added a comment - Github user twalthr commented on the issue: https://github.com/apache/flink/pull/3799 Thanks @fhueske. I will merge this and create a JIRA for it
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user fhueske commented on the issue:

          https://github.com/apache/flink/pull/3799

          Thanks @twalthr for taking care of this!
          Most of the files have been copied from the Calcite master, so I won't review those. The other changes look good.

          +1 to merge this PR.

          @twalthr, can you also create a JIRA to remove the files when Calcite 1.13 is released?

          Show
          githubbot ASF GitHub Bot added a comment - Github user fhueske commented on the issue: https://github.com/apache/flink/pull/3799 Thanks @twalthr for taking care of this! Most of the files have been copied from the Calcite master, so I won't review those. The other changes look good. +1 to merge this PR. @twalthr, can you also create a JIRA to remove the files when Calcite 1.13 is released?
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user twalthr opened a pull request:

          https://github.com/apache/flink/pull/3799

          FLINK-6409 [table] TUMBLE/HOP/SESSION_START/END do not resolve time field correctly

          This is a temporary fix until the next Calcite release 1.13. It adds 5 Calcite files to the Flink code base and modifies one Calcite file in order to successfully run all tests.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/twalthr/flink FLINK-6409

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/flink/pull/3799.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #3799


          commit 31919bb8be56c55bb601a1e2de74497c2463bdf7
          Author: twalthr <twalthr@apache.org>
          Date: 2017-04-28T15:17:30Z

          FLINK-6409 [table] TUMBLE/HOP/SESSION_START/END do not resolve time field correctly


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user twalthr opened a pull request: https://github.com/apache/flink/pull/3799 FLINK-6409 [table] TUMBLE/HOP/SESSION_START/END do not resolve time field correctly This is a temporary fix until the next Calcite release 1.13. It adds 5 Calcite files to the Flink code base and modifies one Calcite file in order to successfully run all tests. You can merge this pull request into a Git repository by running: $ git pull https://github.com/twalthr/flink FLINK-6409 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/3799.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3799 commit 31919bb8be56c55bb601a1e2de74497c2463bdf7 Author: twalthr <twalthr@apache.org> Date: 2017-04-28T15:17:30Z FLINK-6409 [table] TUMBLE/HOP/SESSION_START/END do not resolve time field correctly

            People

            • Assignee:
              twalthr Timo Walther
              Reporter:
              twalthr Timo Walther
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development