Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Implemented
    • Affects Version/s: 1.3.0
    • Fix Version/s: 1.3.0
    • Component/s: Table API & SQL
    • Labels:
      None

      Description

      When browsing the code, it is found that there are some useless reference in the following file which need cleanup.

      packages.scala
      ExternalCatalogTable
      arithmetic.scala
      array.scala
      ColumnStats

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user sunjincheng121 opened a pull request:

          https://github.com/apache/flink/pull/3795

          Cleanup useless import for packages.scala ExternalCatalogTable arithm…

          In this PR cleanup some useless reference in the following files:
          1. packages.scala
          2. ExternalCatalogTable
          3. arithmetic.scala
          4. array.scala
          5. ColumnStats

          • [x] General
          • The pull request references the related JIRA issue ("FLINK-6406[table] Cleanup useless import")
          • The pull request addresses only one issue
          • Each commit in the PR has a meaningful commit message (including the JIRA id)
          • [ ] Documentation
          • Documentation has been added for new functionality
          • Old documentation affected by the pull request has been updated
          • JavaDoc for public methods has been added
          • [ ] Tests & Build
          • Functionality added by the pull request is covered by tests
          • `mvn clean verify` has been executed successfully locally or a Travis build has passed

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/sunjincheng121/flink FLINK-6406-PR

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/flink/pull/3795.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #3795


          commit d075d5eedb803714f76d5e53d6b38a801df350f1
          Author: sunjincheng121 <sunjincheng121@gmail.com>
          Date: 2017-04-28T06:59:42Z

          FLINK-6406[table] Cleanup useless import for packages.scala ExternalCatalogTable arithmetic.scala array.scala ColumnStats


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user sunjincheng121 opened a pull request: https://github.com/apache/flink/pull/3795 Cleanup useless import for packages.scala ExternalCatalogTable arithm… In this PR cleanup some useless reference in the following files: 1. packages.scala 2. ExternalCatalogTable 3. arithmetic.scala 4. array.scala 5. ColumnStats [x] General The pull request references the related JIRA issue (" FLINK-6406 [table] Cleanup useless import") The pull request addresses only one issue Each commit in the PR has a meaningful commit message (including the JIRA id) [ ] Documentation Documentation has been added for new functionality Old documentation affected by the pull request has been updated JavaDoc for public methods has been added [ ] Tests & Build Functionality added by the pull request is covered by tests `mvn clean verify` has been executed successfully locally or a Travis build has passed You can merge this pull request into a Git repository by running: $ git pull https://github.com/sunjincheng121/flink FLINK-6406 -PR Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/3795.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3795 commit d075d5eedb803714f76d5e53d6b38a801df350f1 Author: sunjincheng121 <sunjincheng121@gmail.com> Date: 2017-04-28T06:59:42Z FLINK-6406 [table] Cleanup useless import for packages.scala ExternalCatalogTable arithmetic.scala array.scala ColumnStats
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/flink/pull/3795

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3795
          Hide
          greghogan Greg Hogan added a comment -

          Implemented in ea54962ebe274fca9adef32a079de61659be12fd

          Show
          greghogan Greg Hogan added a comment - Implemented in ea54962ebe274fca9adef32a079de61659be12fd

            People

            • Assignee:
              sunjincheng121 sunjincheng
              Reporter:
              sunjincheng121 sunjincheng
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development