Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-6400

Lack of protection accessing masterHooks in CheckpointCoordinator#triggerCheckpoint

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.3.0
    • Component/s: None
    • Labels:
      None

      Description

      Here is related code:

          synchronized (triggerLock) {
      ...
            try {
              List<MasterState> masterStates = MasterHooks.triggerMasterHooks(masterHooks.values(),
      

      masterHooks is protected by lock in other methods while triggerLock is only used in CheckpointCoordinator#triggerCheckpoint()

        Activity

        Hide
        StephanEwen Stephan Ewen added a comment -

        I think this is a theoretical issue more. The hooks are not manipulated after the coordinator is instantiated.

        Will patch this anyways, to make the code clear...

        Show
        StephanEwen Stephan Ewen added a comment - I think this is a theoretical issue more. The hooks are not manipulated after the coordinator is instantiated. Will patch this anyways, to make the code clear...
        Hide
        StephanEwen Stephan Ewen added a comment -

        Fixed in fcb13e1f54cc8d634416b41d5fc41518806a1885

        Show
        StephanEwen Stephan Ewen added a comment - Fixed in fcb13e1f54cc8d634416b41d5fc41518806a1885
        Hide
        yuzhihong@gmail.com Ted Yu added a comment -

        Thanks for the quick action, Stephan

        Show
        yuzhihong@gmail.com Ted Yu added a comment - Thanks for the quick action, Stephan

          People

          • Assignee:
            StephanEwen Stephan Ewen
            Reporter:
            yuzhihong@gmail.com Ted Yu
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development