Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-6398

RowSerializer's duplicate should always return a new instance

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.2.0, 1.2.1
    • Fix Version/s: 1.3.0, 1.2.2
    • Component/s: Core
    • Labels:
      None

      Description

      RowSerializer is stateful because of nullMask, we should always return a new instance when duplicating.

        Issue Links

          Activity

          Hide
          fhueske Fabian Hueske added a comment -

          Thanks for finding this bug Kurt Young and Flavio Pompermaier for reporting!

          Show
          fhueske Fabian Hueske added a comment - Thanks for finding this bug Kurt Young and Flavio Pompermaier for reporting!
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user KurtYoung opened a pull request:

          https://github.com/apache/flink/pull/3794

          FLINK-6398 RowSerializer's duplicate should always return a new instance

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/KurtYoung/flink flink-6398

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/flink/pull/3794.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #3794


          commit 29f328493dce3adef828f3a93be171a57f1316b0
          Author: Kurt Young <ykt836@gmail.com>
          Date: 2017-04-27T15:37:21Z

          FLINK-6398 RowSerializer's duplicate should always return a new instance


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user KurtYoung opened a pull request: https://github.com/apache/flink/pull/3794 FLINK-6398 RowSerializer's duplicate should always return a new instance You can merge this pull request into a Git repository by running: $ git pull https://github.com/KurtYoung/flink flink-6398 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/3794.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3794 commit 29f328493dce3adef828f3a93be171a57f1316b0 Author: Kurt Young <ykt836@gmail.com> Date: 2017-04-27T15:37:21Z FLINK-6398 RowSerializer's duplicate should always return a new instance
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user tzulitai commented on the issue:

          https://github.com/apache/flink/pull/3794

          +1 to merge

          Show
          githubbot ASF GitHub Bot added a comment - Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/3794 +1 to merge
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/flink/pull/3794

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3794
          Hide
          aljoscha Aljoscha Krettek added a comment -

          Kurt Young and/or Tzu-Li (Gordon) Tai: Did you think about back-porting this to release-1.2, it should be rather straightforward. That we we will get the fix in an eventual 1.2.2.

          Show
          aljoscha Aljoscha Krettek added a comment - Kurt Young and/or Tzu-Li (Gordon) Tai : Did you think about back-porting this to release-1.2, it should be rather straightforward. That we we will get the fix in an eventual 1.2.2.
          Hide
          ykt836 Kurt Young added a comment -

          Aljoscha Krettek Thanks for the advise, i think it's reasonable to back port it to release-1.2, i will do it.

          Show
          ykt836 Kurt Young added a comment - Aljoscha Krettek Thanks for the advise, i think it's reasonable to back port it to release-1.2, i will do it.
          Hide
          ykt836 Kurt Young added a comment -

          done

          Show
          ykt836 Kurt Young added a comment - done
          Hide
          aljoscha Aljoscha Krettek added a comment -

          Thanks!

          Show
          aljoscha Aljoscha Krettek added a comment - Thanks!

            People

            • Assignee:
              ykt836 Kurt Young
              Reporter:
              ykt836 Kurt Young
            • Votes:
              1 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development