Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-6396

FsSavepointStreamFactoryTest fails on Windows

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.3.0, 1.4.0
    • Fix Version/s: 1.3.0, 1.4.0
    • Component/s: Tests
    • Labels:
      None

      Description

      testDefaultFsParameterLoading fails on Window since java Files and flink Paths are compared directly against each other.

        Issue Links

          Activity

          Hide
          Zentol Chesnay Schepler added a comment -

          1.3: 35b74f2bc2247fe00f894167ce49ab063f2a7e8b
          1.4: 236b373e3d314f3a01e89ae596a0cf1a8fd2ad55

          Show
          Zentol Chesnay Schepler added a comment - 1.3: 35b74f2bc2247fe00f894167ce49ab063f2a7e8b 1.4: 236b373e3d314f3a01e89ae596a0cf1a8fd2ad55
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/flink/pull/3789

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3789
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user zentol commented on the issue:

          https://github.com/apache/flink/pull/3789

          Merging for 1.3/1.4.

          Show
          githubbot ASF GitHub Bot added a comment - Github user zentol commented on the issue: https://github.com/apache/flink/pull/3789 Merging for 1.3/1.4.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user StephanEwen commented on the issue:

          https://github.com/apache/flink/pull/3789

          Makes sense, +1 to merge this

          Show
          githubbot ASF GitHub Bot added a comment - Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3789 Makes sense, +1 to merge this
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user zentol opened a pull request:

          https://github.com/apache/flink/pull/3789

          FLINK-6396 Fix FsSavepointStreamFactoryTest on Windows

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/zentol/flink 6396_fs_factory

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/flink/pull/3789.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #3789


          commit d1267ec929732ecfadcca7d36eec54b39b201ad6
          Author: zentol <chesnay@apache.org>
          Date: 2017-04-27T13:56:48Z

          FLINK-6396 Fix FsSavepointStreamFactoryTest on Windows


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user zentol opened a pull request: https://github.com/apache/flink/pull/3789 FLINK-6396 Fix FsSavepointStreamFactoryTest on Windows You can merge this pull request into a Git repository by running: $ git pull https://github.com/zentol/flink 6396_fs_factory Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/3789.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3789 commit d1267ec929732ecfadcca7d36eec54b39b201ad6 Author: zentol <chesnay@apache.org> Date: 2017-04-27T13:56:48Z FLINK-6396 Fix FsSavepointStreamFactoryTest on Windows

            People

            • Assignee:
              Zentol Chesnay Schepler
              Reporter:
              Zentol Chesnay Schepler
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development