Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-6386

Missing bracket in 'Compiler Limitation' section

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 1.2.0
    • Fix Version/s: 1.3.0
    • Component/s: Documentation
    • Labels:
      None

      Description

      "This means that types such as `Tuple2<String,Integer` or `Collector<String>` declared as..."

      should be

      "This means that types such as `Tuple2<String,Integer>` or `Collector<String>` declared as..."

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user bowenli86 opened a pull request:

          https://github.com/apache/flink/pull/3775

          FLINK-6386 Missing bracket in 'Compiler Limitation' section

          Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
          If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
          In addition to going through the list, please provide a meaningful description of your changes.

          • [x] General
          • The pull request references the related JIRA issue ("FLINK-6386 Missing bracket in 'Compiler Limitation' section")
          • The pull request addresses only one issue
          • Each commit in the PR has a meaningful commit message (including the JIRA id)
          • [x] Documentation
          • Documentation has been added for new functionality
          • Old documentation affected by the pull request has been updated
          • JavaDoc for public methods has been added
          • [x] Tests & Build
          • Functionality added by the pull request is covered by tests
          • `mvn clean verify` has been executed successfully locally or a Travis build has passed

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/bowenli86/flink FLINK-6386

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/flink/pull/3775.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #3775


          commit 1533645864465d4ce174d5e9eef3cbb11dead5e3
          Author: Bowen Li <bowenli86@gmail.com>
          Date: 2017-04-26T02:55:25Z

          FLINK-6386 Missing bracket in 'Compiler Limitation' section


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user bowenli86 opened a pull request: https://github.com/apache/flink/pull/3775 FLINK-6386 Missing bracket in 'Compiler Limitation' section Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration. If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide] ( http://flink.apache.org/how-to-contribute.html ). In addition to going through the list, please provide a meaningful description of your changes. [x] General The pull request references the related JIRA issue (" FLINK-6386 Missing bracket in 'Compiler Limitation' section") The pull request addresses only one issue Each commit in the PR has a meaningful commit message (including the JIRA id) [x] Documentation Documentation has been added for new functionality Old documentation affected by the pull request has been updated JavaDoc for public methods has been added [x] Tests & Build Functionality added by the pull request is covered by tests `mvn clean verify` has been executed successfully locally or a Travis build has passed You can merge this pull request into a Git repository by running: $ git pull https://github.com/bowenli86/flink FLINK-6386 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/3775.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3775 commit 1533645864465d4ce174d5e9eef3cbb11dead5e3 Author: Bowen Li <bowenli86@gmail.com> Date: 2017-04-26T02:55:25Z FLINK-6386 Missing bracket in 'Compiler Limitation' section
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user zentol commented on a diff in the pull request:

          https://github.com/apache/flink/pull/3775#discussion_r113378988

          — Diff: docs/dev/java8.md —
          @@ -104,7 +104,7 @@ input.filter(line -> !line.contains("not"))
          Currently, Flink only supports jobs containing Lambda Expressions completely if they are *compiled with the Eclipse JDT compiler contained in Eclipse Luna 4.4.2 (and above)*.

          Only the Eclipse JDT compiler preserves the generic type information necessary to use the entire Lambda Expressions feature type-safely.
          -Other compilers such as the OpenJDK's and Oracle JDK's `javac` throw away all generic parameters related to Lambda Expressions. This means that types such as `Tuple2<String,Integer` or `Collector<String>` declared as a Lambda function input or output parameter will be pruned to `Tuple2` or `Collector` in the compiled `.class` files, which is too little information for the Flink Compiler.
          +Other compilers such as the OpenJDK's and Oracle JDK's `javac` throw away all generic parameters related to Lambda Expressions. This means that types such as `Tuple2<String,Integer>` or `Collector<String>` declared as a Lambda function input or output parameter will be pruned to `Tuple2` or `Collector` in the compiled `.class` files, which is too little information for the Flink Compiler.
          — End diff –

          could you also add a space after the comma `Tuple2<...>` and lower case "Compiler" at the very end?

          Show
          githubbot ASF GitHub Bot added a comment - Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3775#discussion_r113378988 — Diff: docs/dev/java8.md — @@ -104,7 +104,7 @@ input.filter(line -> !line.contains("not")) Currently, Flink only supports jobs containing Lambda Expressions completely if they are * compiled with the Eclipse JDT compiler contained in Eclipse Luna 4.4.2 (and above) *. Only the Eclipse JDT compiler preserves the generic type information necessary to use the entire Lambda Expressions feature type-safely. -Other compilers such as the OpenJDK's and Oracle JDK's `javac` throw away all generic parameters related to Lambda Expressions. This means that types such as `Tuple2<String,Integer` or `Collector<String>` declared as a Lambda function input or output parameter will be pruned to `Tuple2` or `Collector` in the compiled `.class` files, which is too little information for the Flink Compiler. +Other compilers such as the OpenJDK's and Oracle JDK's `javac` throw away all generic parameters related to Lambda Expressions. This means that types such as `Tuple2<String,Integer>` or `Collector<String>` declared as a Lambda function input or output parameter will be pruned to `Tuple2` or `Collector` in the compiled `.class` files, which is too little information for the Flink Compiler. — End diff – could you also add a space after the comma `Tuple2<...>` and lower case "Compiler" at the very end?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user tillrohrmann commented on the issue:

          https://github.com/apache/flink/pull/3775

          LGTM. Thanks for your contribution @bowenli86. Merging this PR.

          Show
          githubbot ASF GitHub Bot added a comment - Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/3775 LGTM. Thanks for your contribution @bowenli86. Merging this PR.
          Hide
          till.rohrmann Till Rohrmann added a comment -

          Fixed via 753763ad186995b16f0ec67cf71cdf18f1d82726

          Show
          till.rohrmann Till Rohrmann added a comment - Fixed via 753763ad186995b16f0ec67cf71cdf18f1d82726
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/flink/pull/3775

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3775

            People

            • Assignee:
              phoenixjiangnan Bowen Li
              Reporter:
              phoenixjiangnan Bowen Li
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development