[FLINK-6381] Unnecessary synchronized object in BucketingSink

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.3.0
• Component/s: Connectors / FileSystem
• Assignee: zhangminglei
• Reporter: zhangminglei
• Created: 25/Apr/17 11:07
• Updated: 16/May/17 14:33
• Resolved: 16/May/17 12:32

Description

It seems that currently there are two places should not employ the synchronized to describe pendingFilesPerCheckpoint, as it is only restored state object for checkpoint and no sharing of the data-structure between different threads, as follows.

 private void handleRestoredRollingSinkState(RollingSink.BucketState restoredState) {
     ...
    synchronized (restoredState.pendingFilesPerCheckpoint) {
			restoredState.pendingFilesPerCheckpoint.clear();
		}
     ...
}

and

private void handleRestoredBucketState(State<T> restoredState) {       
    ...
    synchronized (bucketState.pendingFilesPerCheckpoint) {
	     	        bucketState.pendingFilesPerCheckpoint.clear();
		}
 } 

Hi, kkl0u. Is there any other stuff shoud add here ? Would you mind have a more thorough look in this class ?

Issue Links

• links to: GitHub Pull Request #3820