Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-6338

SimpleStringUtils should be called StringValueUtils

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 1.2.0
    • Fix Version/s: 1.3.0
    • Component/s: Core
    • Labels:
      None

      Issue Links

        Activity

        Hide
        StephanEwen Stephan Ewen added a comment -

        Fixed in 42328bd9b7f216e4c3aae2086b822b4a3a564970

        Show
        StephanEwen Stephan Ewen added a comment - Fixed in 42328bd9b7f216e4c3aae2086b822b4a3a564970
        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user huawei-flink opened a pull request:

        https://github.com/apache/flink/pull/3783

        FLINK-6338 Add support for DISTINCT into Code Generated Aggregations

        Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
        If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
        In addition to going through the list, please provide a meaningful description of your changes.

        • [ ] General
        • The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
        • The pull request addresses only one issue
        • Each commit in the PR has a meaningful commit message (including the JIRA id)
        • [ ] Documentation
        • Documentation has been added for new functionality
        • Old documentation affected by the pull request has been updated
        • JavaDoc for public methods has been added
        • [ ] Tests & Build
        • Functionality added by the pull request is covered by tests
        • `mvn clean verify` has been executed successfully locally or a Travis build has passed

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/stefanobortoli/flink FLINK-6338

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/flink/pull/3783.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #3783


        commit 55e0a8d38187bef22b6135db7f4a5c1cc8f15811
        Author: Stefano Bortoli <s.bortoli@gmail.com>
        Date: 2017-04-26T17:22:04Z

        Added code generation distinct aggregation logic


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user huawei-flink opened a pull request: https://github.com/apache/flink/pull/3783 FLINK-6338 Add support for DISTINCT into Code Generated Aggregations Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration. If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide] ( http://flink.apache.org/how-to-contribute.html ). In addition to going through the list, please provide a meaningful description of your changes. [ ] General The pull request references the related JIRA issue (" [FLINK-XXX] Jira title text") The pull request addresses only one issue Each commit in the PR has a meaningful commit message (including the JIRA id) [ ] Documentation Documentation has been added for new functionality Old documentation affected by the pull request has been updated JavaDoc for public methods has been added [ ] Tests & Build Functionality added by the pull request is covered by tests `mvn clean verify` has been executed successfully locally or a Travis build has passed You can merge this pull request into a Git repository by running: $ git pull https://github.com/stefanobortoli/flink FLINK-6338 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/3783.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3783 commit 55e0a8d38187bef22b6135db7f4a5c1cc8f15811 Author: Stefano Bortoli <s.bortoli@gmail.com> Date: 2017-04-26T17:22:04Z Added code generation distinct aggregation logic
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user huawei-flink commented on the issue:

        https://github.com/apache/flink/pull/3783

        @fhueske please have a look at this PR, it contains just the code generation part with optional distinct.

        Show
        githubbot ASF GitHub Bot added a comment - Github user huawei-flink commented on the issue: https://github.com/apache/flink/pull/3783 @fhueske please have a look at this PR, it contains just the code generation part with optional distinct.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user zentol commented on the issue:

        https://github.com/apache/flink/pull/3783

        Please fix the PR title, you are referencing the wrong JIRA.

        Show
        githubbot ASF GitHub Bot added a comment - Github user zentol commented on the issue: https://github.com/apache/flink/pull/3783 Please fix the PR title, you are referencing the wrong JIRA.

          People

          • Assignee:
            StephanEwen Stephan Ewen
            Reporter:
            StephanEwen Stephan Ewen
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development