Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-6317

History server - wrong default directory

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.3.0
    • Fix Version/s: 1.3.0
    • Component/s: History Server
    • Labels:

      Description

      When the history server is started without a directory specified in the configuration file, it will use some random directory located in the Java Temp directory. Unfortunately, a file separator is missing:

      HistoryServer.java@L139-L143
      String webDirectory = config.getString(HistoryServerOptions.HISTORY_SERVER_WEB_DIR);
      if (webDirectory == null) {
      	webDirectory = System.getProperty("java.io.tmpdir") + "flink-web-history-" + UUID.randomUUID();
      }
      webDir = new File(webDirectory);
      

      It should be

      webDirectory = System.getProperty("java.io.tmpdir") + File.separator +  "flink-web-history-" + UUID.randomUUID();
      

        Issue Links

          Activity

          Hide
          Zentol Chesnay Schepler added a comment -

          1.3: 82a258bf63260a723a76fc4bb42ecac50a66ff99

          Show
          Zentol Chesnay Schepler added a comment - 1.3: 82a258bf63260a723a76fc4bb42ecac50a66ff99
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/flink/pull/3731

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3731
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user zentol commented on the issue:

          https://github.com/apache/flink/pull/3731

          Good catch, merging.

          Show
          githubbot ASF GitHub Bot added a comment - Github user zentol commented on the issue: https://github.com/apache/flink/pull/3731 Good catch, merging.
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user LorenzBuehmann opened a pull request:

          https://github.com/apache/flink/pull/3731

          FLINK-6317 Fix wrong default directory for history server

          This PR will fix the issue with the missing file separator when using the default Java temp directory for the history server.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/LorenzBuehmann/flink master

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/flink/pull/3731.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #3731


          commit 85aa6079fe610fe4cce066da90edcc7cf87a9704
          Author: Lorenz Buehmann <buehmann@informatik.uni-leipzig.de>
          Date: 2017-01-06T12:34:13Z

          [Flink-5378] Bumped Scopt version to 3.5.0.

          This will also allow for using comma-separated values in the CLI.

          commit ae62e2d962133e0cb90b26a6d4764be263bdaf41
          Author: Lorenz Buehmann <buehmann@informatik.uni-leipzig.de>
          Date: 2017-04-18T07:15:05Z

          Merge branch 'master' of github.com:LorenzBuehmann/flink

          commit c815bad3817f22d711c108a97f11c68df2b5d3db
          Author: Lorenz Buehmann <buehmann@informatik.uni-leipzig.de>
          Date: 2017-04-18T07:28:18Z

          FLINK-6317 Fix wrong default directory for history server


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user LorenzBuehmann opened a pull request: https://github.com/apache/flink/pull/3731 FLINK-6317 Fix wrong default directory for history server This PR will fix the issue with the missing file separator when using the default Java temp directory for the history server. You can merge this pull request into a Git repository by running: $ git pull https://github.com/LorenzBuehmann/flink master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/3731.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3731 commit 85aa6079fe610fe4cce066da90edcc7cf87a9704 Author: Lorenz Buehmann <buehmann@informatik.uni-leipzig.de> Date: 2017-01-06T12:34:13Z [Flink-5378] Bumped Scopt version to 3.5.0. This will also allow for using comma-separated values in the CLI. commit ae62e2d962133e0cb90b26a6d4764be263bdaf41 Author: Lorenz Buehmann <buehmann@informatik.uni-leipzig.de> Date: 2017-04-18T07:15:05Z Merge branch 'master' of github.com:LorenzBuehmann/flink commit c815bad3817f22d711c108a97f11c68df2b5d3db Author: Lorenz Buehmann <buehmann@informatik.uni-leipzig.de> Date: 2017-04-18T07:28:18Z FLINK-6317 Fix wrong default directory for history server

            People

            • Assignee:
              Unassigned
              Reporter:
              LorenzB Lorenz B├╝hmann
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development