Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.3.0
    • Component/s: JobManager
    • Labels:
      None

      Description

      As there's a Major bug(https://issues.apache.org/jira/browse/CURATOR-344) in curator release used by flink, we need to update the release to 2.12.0 to avoid potential block in flink. (flink use recipes in checkpoint coordinator and we have already occurred problem in zookeeper failover when we're trying to fix https://issues.apache.org/jira/browse/FLINK-6174)

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user WangTaoTheTonic opened a pull request:

          https://github.com/apache/flink/pull/3727

          FLINK-6312update curator version to 2.12.0 to avoid potential block

          As there's a Major bug(CURATOR-344(https://issues.apache.org/jira/browse/CURATOR-344)) in curator release used by flink, we need to update the release to 2.12.0 to avoid potential block in flink.

          (flink use recipes in checkpoint coordinator and we have already occurred problem in zookeeper failover when we're trying to fix FLINK-6174(https://issues.apache.org/jira/browse/FLINK-6174))

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/WangTaoTheTonic/flink FLINK-6312

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/flink/pull/3727.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #3727


          commit 014b042006c0d6b1939e00c68e7d15ce8262400a
          Author: WangTaoTheTonic <wangtao111@huawei.com>
          Date: 2017-04-17T06:55:27Z

          update curator version to 2.12.0 to avoid potential block


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user WangTaoTheTonic opened a pull request: https://github.com/apache/flink/pull/3727 FLINK-6312 update curator version to 2.12.0 to avoid potential block As there's a Major bug( CURATOR-344 ( https://issues.apache.org/jira/browse/CURATOR-344 )) in curator release used by flink, we need to update the release to 2.12.0 to avoid potential block in flink. (flink use recipes in checkpoint coordinator and we have already occurred problem in zookeeper failover when we're trying to fix FLINK-6174 ( https://issues.apache.org/jira/browse/FLINK-6174 )) You can merge this pull request into a Git repository by running: $ git pull https://github.com/WangTaoTheTonic/flink FLINK-6312 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/3727.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3727 commit 014b042006c0d6b1939e00c68e7d15ce8262400a Author: WangTaoTheTonic <wangtao111@huawei.com> Date: 2017-04-17T06:55:27Z update curator version to 2.12.0 to avoid potential block
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user StephanEwen commented on the issue:

          https://github.com/apache/flink/pull/3727

          Good idea to upgrade Curator.
          Unfortunately, it seems some behavior in Curator has changed. The change causes many tests to hang/fail:

          https://travis-ci.org/apache/flink/builds/222777791

          I think this would need to be stabilized before we can merge the fix. Can you look into this?

          Show
          githubbot ASF GitHub Bot added a comment - Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3727 Good idea to upgrade Curator. Unfortunately, it seems some behavior in Curator has changed. The change causes many tests to hang/fail: https://travis-ci.org/apache/flink/builds/222777791 I think this would need to be stabilized before we can merge the fix. Can you look into this?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user WangTaoTheTonic commented on the issue:

          https://github.com/apache/flink/pull/3727

          Sure. Seems like it will take a little long time but i'll try my best

          Show
          githubbot ASF GitHub Bot added a comment - Github user WangTaoTheTonic commented on the issue: https://github.com/apache/flink/pull/3727 Sure. Seems like it will take a little long time but i'll try my best
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user StephanEwen commented on the issue:

          https://github.com/apache/flink/pull/3727

          Thanks a lot, @WangTaoTheTonic !

          Show
          githubbot ASF GitHub Bot added a comment - Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3727 Thanks a lot, @WangTaoTheTonic !
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user WangTaoTheTonic commented on the issue:

          https://github.com/apache/flink/pull/3727

          @StephanEwen All tests passed!

          Show
          githubbot ASF GitHub Bot added a comment - Github user WangTaoTheTonic commented on the issue: https://github.com/apache/flink/pull/3727 @StephanEwen All tests passed!
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user StephanEwen commented on the issue:

          https://github.com/apache/flink/pull/3727

          Thanks for the fix. Merging this...

          Show
          githubbot ASF GitHub Bot added a comment - Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3727 Thanks for the fix. Merging this...
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user StephanEwen commented on the issue:

          https://github.com/apache/flink/pull/3727

          Has been merged in aadfe45a880d0f71f23c7a742ff5264e8dc14bf8

          @WangTaoTheTonic Since the PR was not auto-closed, can you close the PR manually?

          Show
          githubbot ASF GitHub Bot added a comment - Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3727 Has been merged in aadfe45a880d0f71f23c7a742ff5264e8dc14bf8 @WangTaoTheTonic Since the PR was not auto-closed, can you close the PR manually?
          Hide
          StephanEwen Stephan Ewen added a comment -

          Fixed via aadfe45a880d0f71f23c7a742ff5264e8dc14bf8

          Show
          StephanEwen Stephan Ewen added a comment - Fixed via aadfe45a880d0f71f23c7a742ff5264e8dc14bf8
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user WangTaoTheTonic closed the pull request at:

          https://github.com/apache/flink/pull/3727

          Show
          githubbot ASF GitHub Bot added a comment - Github user WangTaoTheTonic closed the pull request at: https://github.com/apache/flink/pull/3727

            People

            • Assignee:
              WangTao Tao Wang
              Reporter:
              WangTao Tao Wang
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development