Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Implemented
    • Affects Version/s: None
    • Fix Version/s: 1.3.0
    • Component/s: Table API & SQL
    • Labels:
      None

      Description

      There are some classes(as follow) have useless import, I want clear them before release 1.3.

      DataSetSlideTimeWindowAggFlatMapFunction
      CommonScan
      FlinkRel
      StreamTableSourceScanRule
      DataStreamOverAggregateRule
      DataStreamAggregateRule
      

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user sunjincheng121 opened a pull request:

          https://github.com/apache/flink/pull/3717

          FLINK-6304[table]Clear a lot of useless import

          Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
          If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
          In addition to going through the list, please provide a meaningful description of your changes.

          • [x] General
          • The pull request references the related JIRA issue ("FLINK-6304Clear a lot of useless import")
          • The pull request addresses only one issue
          • Each commit in the PR has a meaningful commit message (including the JIRA id)
          • [ ] Documentation
          • Documentation has been added for new functionality
          • Old documentation affected by the pull request has been updated
          • JavaDoc for public methods has been added
          • [ ] Tests & Build
          • Functionality added by the pull request is covered by tests
          • `mvn clean verify` has been executed successfully locally or a Travis build has passed

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/sunjincheng121/flink FLINK-6304-PR

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/flink/pull/3717.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #3717


          commit c34f38d61d6b8fc69f48e70f2feb6f225a5eca96
          Author: sunjincheng121 <sunjincheng121@gmail.com>
          Date: 2017-04-13T10:01:40Z

          FLINK-6304[table]Clear a lot of useless import


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user sunjincheng121 opened a pull request: https://github.com/apache/flink/pull/3717 FLINK-6304 [table] Clear a lot of useless import Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration. If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide] ( http://flink.apache.org/how-to-contribute.html ). In addition to going through the list, please provide a meaningful description of your changes. [x] General The pull request references the related JIRA issue (" FLINK-6304 Clear a lot of useless import") The pull request addresses only one issue Each commit in the PR has a meaningful commit message (including the JIRA id) [ ] Documentation Documentation has been added for new functionality Old documentation affected by the pull request has been updated JavaDoc for public methods has been added [ ] Tests & Build Functionality added by the pull request is covered by tests `mvn clean verify` has been executed successfully locally or a Travis build has passed You can merge this pull request into a Git repository by running: $ git pull https://github.com/sunjincheng121/flink FLINK-6304 -PR Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/3717.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3717 commit c34f38d61d6b8fc69f48e70f2feb6f225a5eca96 Author: sunjincheng121 <sunjincheng121@gmail.com> Date: 2017-04-13T10:01:40Z FLINK-6304 [table] Clear a lot of useless import
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user greghogan commented on the issue:

          https://github.com/apache/flink/pull/3717

          Thanks for the cleanup. Looks good, tests have passed, merging ...

          Show
          githubbot ASF GitHub Bot added a comment - Github user greghogan commented on the issue: https://github.com/apache/flink/pull/3717 Thanks for the cleanup. Looks good, tests have passed, merging ...
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/flink/pull/3717

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3717
          Hide
          greghogan Greg Hogan added a comment -

          Implemented in a30f29f6895591997a732714630e79c097dff5fc

          Show
          greghogan Greg Hogan added a comment - Implemented in a30f29f6895591997a732714630e79c097dff5fc

            People

            • Assignee:
              sunjincheng121 sunjincheng
              Reporter:
              sunjincheng121 sunjincheng
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development