[FLINK-6284] Incorrect sorting of completed checkpoints in ZooKeeperCompletedCheckpointStore

• Type: Bug
• Status: Resolved
• Priority: Blocker
• Resolution: Fixed
• Fix Version/s: 1.3.0, 1.4.0
• Component/s: Runtime / State Backends
• Assignee: Till Rohrmann
• Reporter: Xiaogang Shi
• Created: 10/Apr/17 04:03
• Updated: 17/May/17 06:23
• Resolved: 17/May/17 06:22

Description

Now all completed checkpoints are sorted in their paths when they are recovered in ZooKeeperCompletedCheckpointStore . In the cases where the latest checkpoint's id is not the largest in lexical order (e.g., "100" is smaller than "99" in lexical order), Flink will not recover from the latest completed checkpoint.

The problem can be easily observed by setting the checkpoint ids in ZooKeeperCompletedCheckpointStoreITCase#testRecover() to be 99, 100 and 101.

To fix the problem, we should explicitly sort found checkpoints in their checkpoint ids, without the usage of ZooKeeperStateHandleStore#getAllSortedByName()

Issue Links

• links to: GitHub Pull Request #3881
• links to: GitHub Pull Request #3884