Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-6279

the digest of VolcanoRuleMatch matched different table sources with same field names may be same

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.3.0
    • Component/s: Table API & SQL
    • Labels:
      None

      Description

      toString of TableSourceScan should contain table name and result of explainSource to distinguish the difference of table sources with same field names. Otherwise the digest of VolcanoRuleMatch matched those table sources may be same.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user godfreyhe opened a pull request:

          https://github.com/apache/flink/pull/3699

          FLINK-6279 [table] fix bug: the digest of VolcanoRuleMatch matched …

          toString of TableSourceScan should contain table name and result of explainSource to distinguish the difference of table sources with same field names. Otherwise the digest of VolcanoRuleMatch matched those table sources may be same.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/godfreyhe/flink FLINK-6279

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/flink/pull/3699.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #3699


          commit b78781c455d6220c6461205cb6ff95a56786cf59
          Author: godfreyhe <godfreyhe@163.com>
          Date: 2017-04-07T13:41:29Z

          FLINK-6279 [table] fix bug: the digest of VolcanoRuleMatch matched different table sources with same field names may be same


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user godfreyhe opened a pull request: https://github.com/apache/flink/pull/3699 FLINK-6279 [table] fix bug: the digest of VolcanoRuleMatch matched … toString of TableSourceScan should contain table name and result of explainSource to distinguish the difference of table sources with same field names. Otherwise the digest of VolcanoRuleMatch matched those table sources may be same. You can merge this pull request into a Git repository by running: $ git pull https://github.com/godfreyhe/flink FLINK-6279 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/3699.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3699 commit b78781c455d6220c6461205cb6ff95a56786cf59 Author: godfreyhe <godfreyhe@163.com> Date: 2017-04-07T13:41:29Z FLINK-6279 [table] fix bug: the digest of VolcanoRuleMatch matched different table sources with same field names may be same
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user fhueske commented on the issue:

          https://github.com/apache/flink/pull/3699

          Hi @godfreyhe, thanks for the fix!
          Will merge this PR.

          Show
          githubbot ASF GitHub Bot added a comment - Github user fhueske commented on the issue: https://github.com/apache/flink/pull/3699 Hi @godfreyhe, thanks for the fix! Will merge this PR.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/flink/pull/3699

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3699
          Hide
          fhueske Fabian Hueske added a comment -

          Fixed with 697cc96106846547ff856aa5e478fee037ffde1a

          Show
          fhueske Fabian Hueske added a comment - Fixed with 697cc96106846547ff856aa5e478fee037ffde1a

            People

            • Assignee:
              godfreyhe godfrey he
              Reporter:
              godfreyhe godfrey he
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development