Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-6256

Fix documentation of ProcessFunction.

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 1.3.0
    • Fix Version/s: 1.3.0
    • Component/s: Documentation
    • Labels:
      None

      Description

      In the code example on how to define an OutputTag and how to use it to extract the side-output stream, the name of the defined output tag and that of the one used in the getSideOutput() differ.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user zentol opened a pull request:

          https://github.com/apache/flink/pull/3684

          FLINK-6256 Fix outputTag variable name in Side Output docs

          @kl0u Is this the issue of the JIRA or was there something else?

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/zentol/flink 6256_output_docs

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/flink/pull/3684.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #3684


          commit ced4e018cf396d233473867ce6239a60b8d9fc27
          Author: zentol <chesnay@apache.org>
          Date: 2017-04-06T09:45:56Z

          FLINK-6256 Fix outputTag variable name in Side Output docs


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user zentol opened a pull request: https://github.com/apache/flink/pull/3684 FLINK-6256 Fix outputTag variable name in Side Output docs @kl0u Is this the issue of the JIRA or was there something else? You can merge this pull request into a Git repository by running: $ git pull https://github.com/zentol/flink 6256_output_docs Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/3684.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3684 commit ced4e018cf396d233473867ce6239a60b8d9fc27 Author: zentol <chesnay@apache.org> Date: 2017-04-06T09:45:56Z FLINK-6256 Fix outputTag variable name in Side Output docs
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user kl0u commented on the issue:

          https://github.com/apache/flink/pull/3684

          @zentol Yes, this is the main issue, but you could also use the same name for the output tags between Java and Scala. Java uses "side-output" while Scala uses "string-side-output".

          Show
          githubbot ASF GitHub Bot added a comment - Github user kl0u commented on the issue: https://github.com/apache/flink/pull/3684 @zentol Yes, this is the main issue, but you could also use the same name for the output tags between Java and Scala. Java uses "side-output" while Scala uses "string-side-output".
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user zentol commented on the issue:

          https://github.com/apache/flink/pull/3684

          @kl0u done; i went with "side-output".

          Show
          githubbot ASF GitHub Bot added a comment - Github user zentol commented on the issue: https://github.com/apache/flink/pull/3684 @kl0u done; i went with "side-output".
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user kl0u commented on a diff in the pull request:

          https://github.com/apache/flink/pull/3684#discussion_r110125718

          — Diff: docs/dev/stream/side_output.md —
          @@ -41,7 +41,7 @@ side output stream:

          {% highlight java %}

          // this needs to be an anonymous inner class, so that we can analyze the type
          -OutputTag<String> outputTag = new OutputTag<String>("string-side-output") {};
          +OutputTag<String> outputTag = new OutputTag<String>("side-output") {};
          — End diff –

          You should update the Scala.

          Show
          githubbot ASF GitHub Bot added a comment - Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/3684#discussion_r110125718 — Diff: docs/dev/stream/side_output.md — @@ -41,7 +41,7 @@ side output stream: {% highlight java %} // this needs to be an anonymous inner class, so that we can analyze the type -OutputTag<String> outputTag = new OutputTag<String>("string-side-output") {}; +OutputTag<String> outputTag = new OutputTag<String>("side-output") {}; — End diff – You should update the Scala.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user zentol commented on a diff in the pull request:

          https://github.com/apache/flink/pull/3684#discussion_r110130934

          — Diff: docs/dev/stream/side_output.md —
          @@ -41,7 +41,7 @@ side output stream:

          {% highlight java %}

          // this needs to be an anonymous inner class, so that we can analyze the type
          -OutputTag<String> outputTag = new OutputTag<String>("string-side-output") {};
          +OutputTag<String> outputTag = new OutputTag<String>("side-output") {};
          — End diff –

          done.

          Show
          githubbot ASF GitHub Bot added a comment - Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3684#discussion_r110130934 — Diff: docs/dev/stream/side_output.md — @@ -41,7 +41,7 @@ side output stream: {% highlight java %} // this needs to be an anonymous inner class, so that we can analyze the type -OutputTag<String> outputTag = new OutputTag<String>("string-side-output") {}; +OutputTag<String> outputTag = new OutputTag<String>("side-output") {}; — End diff – done.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user kl0u commented on the issue:

          https://github.com/apache/flink/pull/3684

          +1 to merge.

          Show
          githubbot ASF GitHub Bot added a comment - Github user kl0u commented on the issue: https://github.com/apache/flink/pull/3684 +1 to merge.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user zentol commented on the issue:

          https://github.com/apache/flink/pull/3684

          merging.

          Show
          githubbot ASF GitHub Bot added a comment - Github user zentol commented on the issue: https://github.com/apache/flink/pull/3684 merging.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/flink/pull/3684

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3684
          Hide
          Zentol Chesnay Schepler added a comment -

          1.3: a6355edd904c2efe2ee37118132b0add5a2e5588

          Show
          Zentol Chesnay Schepler added a comment - 1.3: a6355edd904c2efe2ee37118132b0add5a2e5588

            People

            • Assignee:
              Zentol Chesnay Schepler
              Reporter:
              kkl0u Kostas Kloudas
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development