Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-6254

Consolidate late data methods on PatternStream and WindowedStream

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.3.0
    • Component/s: CEP
    • Labels:
      None

      Description

      WindowedStream has sideOutputLateData(OutputTag<T> outputTag) while PatternStream has withLateDataOutputTag(OutputTag<T> outputTag).

      WindowedStream had the method first so we should stick to that naming scheme.

        Issue Links

          Activity

          Hide
          kkl0u Kostas Kloudas added a comment -

          Merged at 1b6baddca07bfba6093951e82ac9108cf4728f2a

          Show
          kkl0u Kostas Kloudas added a comment - Merged at 1b6baddca07bfba6093951e82ac9108cf4728f2a
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user kl0u closed the pull request at:

          https://github.com/apache/flink/pull/3668

          Show
          githubbot ASF GitHub Bot added a comment - Github user kl0u closed the pull request at: https://github.com/apache/flink/pull/3668
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user kl0u commented on the issue:

          https://github.com/apache/flink/pull/3668

          Thanks @aljoscha ! Merging this.

          Show
          githubbot ASF GitHub Bot added a comment - Github user kl0u commented on the issue: https://github.com/apache/flink/pull/3668 Thanks @aljoscha ! Merging this.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user aljoscha commented on the issue:

          https://github.com/apache/flink/pull/3668

          LGTM! 👍

          Show
          githubbot ASF GitHub Bot added a comment - Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/3668 LGTM! 👍
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user kl0u opened a pull request:

          https://github.com/apache/flink/pull/3668

          FLINK-6254 [cep] Same method name for late data outputs on PatternStream and windowing.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/kl0u/flink cep-late-consolidation

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/flink/pull/3668.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #3668


          commit f24b0eba9d82ea91f5d44e747e8a64e94cb71cd5
          Author: kl0u <kkloudas@gmail.com>
          Date: 2017-04-03T15:39:02Z

          FLINK-6254 [cep] Same method name for late data outputs on PatternStream and WindowedStream


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user kl0u opened a pull request: https://github.com/apache/flink/pull/3668 FLINK-6254 [cep] Same method name for late data outputs on PatternStream and windowing. You can merge this pull request into a Git repository by running: $ git pull https://github.com/kl0u/flink cep-late-consolidation Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/3668.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3668 commit f24b0eba9d82ea91f5d44e747e8a64e94cb71cd5 Author: kl0u <kkloudas@gmail.com> Date: 2017-04-03T15:39:02Z FLINK-6254 [cep] Same method name for late data outputs on PatternStream and WindowedStream

            People

            • Assignee:
              kkl0u Kostas Kloudas
              Reporter:
              aljoscha Aljoscha Krettek
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development