Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-6212

Missing reference to flink-avro dependency

    Details

      Description

      In the Connectors page of the Batch (DataSet API) there is a section called "Avro support in Flink"

      This section mentions the use of certain classes that are part of the flink-avro dependency but this fact is mentioned nowhere.

      This explanation should be added as well as an xml snippet with the maven dependency as in other parts of the documentation.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user omrsin opened a pull request:

          https://github.com/apache/flink/pull/3638

          FLINK-6212

          Adds the reference to the maven dependecy for flink-avro
          in the "Avro support in Flink" section.

          Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
          If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
          In addition to going through the list, please provide a meaningful description of your changes.

          • [ ] General
          • The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
          • The pull request addresses only one issue
          • Each commit in the PR has a meaningful commit message (including the JIRA id)
          • [ ] Documentation
          • Documentation has been added for new functionality
          • Old documentation affected by the pull request has been updated
          • JavaDoc for public methods has been added
          • [ ] Tests & Build
          • Functionality added by the pull request is covered by tests
          • `mvn clean verify` has been executed successfully locally or a Travis build has passed

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/omrsin/flink avro-docs

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/flink/pull/3638.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #3638


          commit e745cd6d02b8a61295d92e92c9e9d3f5a31f22e4
          Author: Omar Erminy <omrsin@gmail.com>
          Date: 2017-03-29T07:35:23Z

          FLINK-6212

          Adds the reference to the maven dependecy for flink-avro
          in the "Avro support in Flink" section.


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user omrsin opened a pull request: https://github.com/apache/flink/pull/3638 FLINK-6212 Adds the reference to the maven dependecy for flink-avro in the "Avro support in Flink" section. Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration. If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide] ( http://flink.apache.org/how-to-contribute.html ). In addition to going through the list, please provide a meaningful description of your changes. [ ] General The pull request references the related JIRA issue (" [FLINK-XXX] Jira title text") The pull request addresses only one issue Each commit in the PR has a meaningful commit message (including the JIRA id) [ ] Documentation Documentation has been added for new functionality Old documentation affected by the pull request has been updated JavaDoc for public methods has been added [ ] Tests & Build Functionality added by the pull request is covered by tests `mvn clean verify` has been executed successfully locally or a Travis build has passed You can merge this pull request into a Git repository by running: $ git pull https://github.com/omrsin/flink avro-docs Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/3638.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3638 commit e745cd6d02b8a61295d92e92c9e9d3f5a31f22e4 Author: Omar Erminy <omrsin@gmail.com> Date: 2017-03-29T07:35:23Z FLINK-6212 Adds the reference to the maven dependecy for flink-avro in the "Avro support in Flink" section.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user rmetzger commented on the issue:

          https://github.com/apache/flink/pull/3638

          Thank you for your contribution

          +1 to merge

          Show
          githubbot ASF GitHub Bot added a comment - Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/3638 Thank you for your contribution +1 to merge
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user zentol commented on the issue:

          https://github.com/apache/flink/pull/3638

          merging.

          Show
          githubbot ASF GitHub Bot added a comment - Github user zentol commented on the issue: https://github.com/apache/flink/pull/3638 merging.
          Hide
          Zentol Chesnay Schepler added a comment -

          1.2: 36b068b08ce76f360e5ac45b0eaffb922b04a529
          1.3: c8f8a41b5942c00c05d78a1e1f58ba50a489a509

          Show
          Zentol Chesnay Schepler added a comment - 1.2: 36b068b08ce76f360e5ac45b0eaffb922b04a529 1.3: c8f8a41b5942c00c05d78a1e1f58ba50a489a509
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/flink/pull/3638

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3638

            People

            • Assignee:
              Unassigned
              Reporter:
              omrsin Omar Erminy
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development