Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 1.3.0
    • Fix Version/s: 1.3.0
    • Component/s: Examples, Python API
    • Labels:
      None

      Description

      Python example in the resource dir is not suitable. Move them to the examples/python dir.
      ```
      <fileSet>
      <directory>../flink-libraries/flink-python/src/main/python/org/apache/flink/python/api</directory>
      <outputDirectory>resources/python</outputDirectory>
      <fileMode>0755</fileMode>
      </fileSet>
      ```

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user shijinkui opened a pull request:

          https://github.com/apache/flink/pull/3628

          FLINK-6201[example] move python example files from resources to the examples

          Python example in the resource dir is not suitable. Move them to the examples/python dir.

          • [X] General
          • The pull request references the related JIRA issue ("FLINK-6201 move python example files from resources to the examples")
          • The pull request addresses only one issue
          • Each commit in the PR has a meaningful commit message (including the JIRA id)
          • [X] Documentation
          • Documentation has been added for new functionality
          • Old documentation affected by the pull request has been updated
          • JavaDoc for public methods has been added
          • [X] Tests & Build
          • Functionality added by the pull request is covered by tests
          • `mvn clean verify` has been executed successfully locally or a Travis build has passed

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/hwstreaming/flink FLINK-6201

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/flink/pull/3628.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #3628


          commit c9eafd960707971d762da2f7d9179404e91b6211
          Author: Jinkui Shi <shijinkui@huawei.com>
          Date: 2017-03-28T06:40:26Z

          FLINK-6201[example] move python example files from resources to the examples


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user shijinkui opened a pull request: https://github.com/apache/flink/pull/3628 FLINK-6201 [example] move python example files from resources to the examples Python example in the resource dir is not suitable. Move them to the examples/python dir. [X] General The pull request references the related JIRA issue (" FLINK-6201 move python example files from resources to the examples") The pull request addresses only one issue Each commit in the PR has a meaningful commit message (including the JIRA id) [X] Documentation Documentation has been added for new functionality Old documentation affected by the pull request has been updated JavaDoc for public methods has been added [X] Tests & Build Functionality added by the pull request is covered by tests `mvn clean verify` has been executed successfully locally or a Travis build has passed You can merge this pull request into a Git repository by running: $ git pull https://github.com/hwstreaming/flink FLINK-6201 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/3628.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3628 commit c9eafd960707971d762da2f7d9179404e91b6211 Author: Jinkui Shi <shijinkui@huawei.com> Date: 2017-03-28T06:40:26Z FLINK-6201 [example] move python example files from resources to the examples
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user zentol commented on the issue:

          https://github.com/apache/flink/pull/3628

          -1. This moves the Flink's entire python library into the examples folder, breaking basically everything.

          You will have to move the configured directory to /resources and exclude the example directory, and move that one specifically to /examples.

          I would also suggest to run an example at least once to make sure you don't break anything.

          Show
          githubbot ASF GitHub Bot added a comment - Github user zentol commented on the issue: https://github.com/apache/flink/pull/3628 -1. This moves the Flink's entire python library into the examples folder, breaking basically everything. You will have to move the configured directory to /resources and exclude the example directory, and move that one specifically to /examples. I would also suggest to run an example at least once to make sure you don't break anything.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user shijinkui commented on the issue:

          https://github.com/apache/flink/pull/3628

          > I would also suggest to run an example at least once to make sure you don't break anything.

          You are right. Only move the example files

          Show
          githubbot ASF GitHub Bot added a comment - Github user shijinkui commented on the issue: https://github.com/apache/flink/pull/3628 > I would also suggest to run an example at least once to make sure you don't break anything. You are right. Only move the example files
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user zentol commented on the issue:

          https://github.com/apache/flink/pull/3628

          Thank you for fixing this so quickly. +1 to merge.

          Show
          githubbot ASF GitHub Bot added a comment - Github user zentol commented on the issue: https://github.com/apache/flink/pull/3628 Thank you for fixing this so quickly. +1 to merge.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user zentol commented on the issue:

          https://github.com/apache/flink/pull/3628

          merging.

          Show
          githubbot ASF GitHub Bot added a comment - Github user zentol commented on the issue: https://github.com/apache/flink/pull/3628 merging.
          Hide
          Zentol Chesnay Schepler added a comment -

          1.3: 995422c461bc2e58bc1590c313b940e05c0fabef

          Show
          Zentol Chesnay Schepler added a comment - 1.3: 995422c461bc2e58bc1590c313b940e05c0fabef
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/flink/pull/3628

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3628

            People

            • Assignee:
              shijinkui shijinkui
              Reporter:
              shijinkui shijinkui
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development