Details

      Issue Links

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user rmetzger opened a pull request:

        https://github.com/apache/flink/pull/3605

        FLINK-6181[Start scripts] Fix regex in start scripts

        This issue has been reported by a user: http://apache-flink-user-mailing-list-archive.2336050.n4.nabble.com/unable-to-add-more-servers-in-zookeeper-quorum-peers-in-flink-1-2-td12321.html

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/rmetzger/flink FLINK-6181

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/flink/pull/3605.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #3605


        commit 24ff85b655badc9890eadc823bb6dfa1d892825a
        Author: Robert Metzger <rmetzger@apache.org>
        Date: 2017-03-23T14:13:25Z

        [hotfix] Fix shading checks

        commit eae1bc24063b133bda86b0ae0ae0977ff42720c8
        Author: Robert Metzger <rmetzger@apache.org>
        Date: 2017-03-24T10:50:11Z

        FLINK-6181[Start scripts] Fix regex in start scripts


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user rmetzger opened a pull request: https://github.com/apache/flink/pull/3605 FLINK-6181 [Start scripts] Fix regex in start scripts This issue has been reported by a user: http://apache-flink-user-mailing-list-archive.2336050.n4.nabble.com/unable-to-add-more-servers-in-zookeeper-quorum-peers-in-flink-1-2-td12321.html You can merge this pull request into a Git repository by running: $ git pull https://github.com/rmetzger/flink FLINK-6181 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/3605.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3605 commit 24ff85b655badc9890eadc823bb6dfa1d892825a Author: Robert Metzger <rmetzger@apache.org> Date: 2017-03-23T14:13:25Z [hotfix] Fix shading checks commit eae1bc24063b133bda86b0ae0ae0977ff42720c8 Author: Robert Metzger <rmetzger@apache.org> Date: 2017-03-24T10:50:11Z FLINK-6181 [Start scripts] Fix regex in start scripts
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user zentol commented on a diff in the pull request:

        https://github.com/apache/flink/pull/3605#discussion_r107911796

        — Diff: tools/travis_mvn_watchdog.sh —
        @@ -164,7 +164,7 @@ watchdog () {

        1. Check the final fat jar for illegal artifacts
          check_shaded_artifacts() {
        • jar tf build-target/lib/flink-dist-*.jar > allClasses
            • End diff –

        What issue is this fixing?

        Show
        githubbot ASF GitHub Bot added a comment - Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3605#discussion_r107911796 — Diff: tools/travis_mvn_watchdog.sh — @@ -164,7 +164,7 @@ watchdog () { Check the final fat jar for illegal artifacts check_shaded_artifacts() { jar tf build-target/lib/flink-dist-*.jar > allClasses End diff – What issue is this fixing?
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user greghogan commented on the issue:

        https://github.com/apache/flink/pull/3605

        Thanks @rmetzger!

        Show
        githubbot ASF GitHub Bot added a comment - Github user greghogan commented on the issue: https://github.com/apache/flink/pull/3605 Thanks @rmetzger!
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user StephanEwen commented on a diff in the pull request:

        https://github.com/apache/flink/pull/3605#discussion_r107923309

        — Diff: tools/travis_mvn_watchdog.sh —
        @@ -164,7 +164,7 @@ watchdog () {

        1. Check the final fat jar for illegal artifacts
          check_shaded_artifacts() {
        • jar tf build-target/lib/flink-dist-*.jar > allClasses
            • End diff –

        I assume with the "-" this only matches something like `flink-dist-1.2-SNAPSHOT` or so and with the fix, it also matched `flink-dist.jar`...

        Show
        githubbot ASF GitHub Bot added a comment - Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/3605#discussion_r107923309 — Diff: tools/travis_mvn_watchdog.sh — @@ -164,7 +164,7 @@ watchdog () { Check the final fat jar for illegal artifacts check_shaded_artifacts() { jar tf build-target/lib/flink-dist-*.jar > allClasses End diff – I assume with the "-" this only matches something like `flink-dist-1.2-SNAPSHOT` or so and with the fix, it also matched `flink-dist.jar`...
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user rmetzger commented on a diff in the pull request:

        https://github.com/apache/flink/pull/3605#discussion_r108001505

        — Diff: tools/travis_mvn_watchdog.sh —
        @@ -164,7 +164,7 @@ watchdog () {

        1. Check the final fat jar for illegal artifacts
          check_shaded_artifacts() {
        • jar tf build-target/lib/flink-dist-*.jar > allClasses
            • End diff –

        The problem is that our dist jar is called `flink-dist_2.10-1.3-SNAPSHOT.jar`. so the old variant didn't match the jar.
        This leads to the following error in all travis build:
        ```
        java.io.FileNotFoundException: build-target/lib/flink-dist-*.jar (No such file or directory)
        at java.util.zip.ZipFile.open(Native Method)
        at java.util.zip.ZipFile.<init>(ZipFile.java:220)
        at java.util.zip.ZipFile.<init>(ZipFile.java:150)
        at java.util.zip.ZipFile.<init>(ZipFile.java:121)
        at sun.tools.jar.Main.list(Main.java:1060)
        at sun.tools.jar.Main.run(Main.java:291)
        at sun.tools.jar.Main.main(Main.java:1233)
        ```
        I'm doing `jar tf` here to check if guava and other libraries are not part of the fat jar.

        Show
        githubbot ASF GitHub Bot added a comment - Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/3605#discussion_r108001505 — Diff: tools/travis_mvn_watchdog.sh — @@ -164,7 +164,7 @@ watchdog () { Check the final fat jar for illegal artifacts check_shaded_artifacts() { jar tf build-target/lib/flink-dist-*.jar > allClasses End diff – The problem is that our dist jar is called `flink-dist_2.10-1.3-SNAPSHOT.jar`. so the old variant didn't match the jar. This leads to the following error in all travis build: ``` java.io.FileNotFoundException: build-target/lib/flink-dist-*.jar (No such file or directory) at java.util.zip.ZipFile.open(Native Method) at java.util.zip.ZipFile.<init>(ZipFile.java:220) at java.util.zip.ZipFile.<init>(ZipFile.java:150) at java.util.zip.ZipFile.<init>(ZipFile.java:121) at sun.tools.jar.Main.list(Main.java:1060) at sun.tools.jar.Main.run(Main.java:291) at sun.tools.jar.Main.main(Main.java:1233) ``` I'm doing `jar tf` here to check if guava and other libraries are not part of the fat jar.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user zentol commented on the issue:

        https://github.com/apache/flink/pull/3605

        merging.

        Show
        githubbot ASF GitHub Bot added a comment - Github user zentol commented on the issue: https://github.com/apache/flink/pull/3605 merging.
        Hide
        Zentol Chesnay Schepler added a comment -

        1.3: dc13500dd5c8061eb75a64a62db6aa13f8fd5408

        Show
        Zentol Chesnay Schepler added a comment - 1.3: dc13500dd5c8061eb75a64a62db6aa13f8fd5408
        Hide
        Zentol Chesnay Schepler added a comment -

        reopening to apply patch to 1.2

        Show
        Zentol Chesnay Schepler added a comment - reopening to apply patch to 1.2
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/flink/pull/3605

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3605
        Hide
        Zentol Chesnay Schepler added a comment -

        1.2: d2a8df4c5556ec30c0de0f8bf874d6c2395a5cbf

        Show
        Zentol Chesnay Schepler added a comment - 1.2: d2a8df4c5556ec30c0de0f8bf874d6c2395a5cbf

          People

          • Assignee:
            rmetzger Robert Metzger
            Reporter:
            rmetzger Robert Metzger
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development