Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.3.0
    • Fix Version/s: 1.3.0
    • Labels:
      None

      Description

      Currently, the NonHaServices and the EmbeddedNonHaServices share the same code base for the JobManager leader election and retrieval. This works if the respective components run in the same process. However, in case of a distributed execution, we have to instantiate StandaloneLeaderRetrieval/ElectionServices to make the leader retrieval possible.

      I propose to instantiate the StandaloneLeaderRetrieval/ElectionServices in the NonHaServices implementation and to use them in case of a distributed non-ha execution setting.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user tillrohrmann opened a pull request:

          https://github.com/apache/flink/pull/3622

          FLINK-6136 Separate EmbeddedHaServices and StandaloneHaServices

          This PR introduces a standalone high availability services implementation which can be used
          in a distributed setting with no HA guarantees. Additionally, it introduces a common base
          class which is also used by the EmbeddedHaServices. This base class instantiates the
          standalone variants of the checkpoint recovery factory, submitted job graphs store, running
          jobs registry and blob store.

          The StandaloneHaServices are instantiated with a fixed address for the Job- and
          ResourceManager. This address and the HighAvailability.DEFAULT_LEADER_ID is returned by
          the corresponding LeaderRetrievalServices when being started.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/tillrohrmann/flink separateNonHaServices

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/flink/pull/3622.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #3622


          commit 3f85d6b3ef41df4e795bb3ef5beecca49606caba
          Author: Till Rohrmann <trohrmann@apache.org>
          Date: 2017-03-21T14:10:15Z

          FLINK-6136 Separate EmbeddedHaServices and StandaloneHaServices

          This PR introduces a standalone high availability services implementation which can be used
          in a distributed setting with no HA guarantees. Additionally, it introduces a common base
          class which is also used by the EmbeddedHaServices. This base class instantiates the
          standalone variants of the checkpoint recovery factory, submitted job graphs store, running
          jobs registry and blob store.

          The StandaloneHaServices are instantiated with a fixed address for the Job- and
          ResourceManager. This address and the HighAvailability.DEFAULT_LEADER_ID is returned by
          the corresponding LeaderRetrievalServices when being started.


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/3622 FLINK-6136 Separate EmbeddedHaServices and StandaloneHaServices This PR introduces a standalone high availability services implementation which can be used in a distributed setting with no HA guarantees. Additionally, it introduces a common base class which is also used by the EmbeddedHaServices. This base class instantiates the standalone variants of the checkpoint recovery factory, submitted job graphs store, running jobs registry and blob store. The StandaloneHaServices are instantiated with a fixed address for the Job- and ResourceManager. This address and the HighAvailability.DEFAULT_LEADER_ID is returned by the corresponding LeaderRetrievalServices when being started. You can merge this pull request into a Git repository by running: $ git pull https://github.com/tillrohrmann/flink separateNonHaServices Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/3622.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3622 commit 3f85d6b3ef41df4e795bb3ef5beecca49606caba Author: Till Rohrmann <trohrmann@apache.org> Date: 2017-03-21T14:10:15Z FLINK-6136 Separate EmbeddedHaServices and StandaloneHaServices This PR introduces a standalone high availability services implementation which can be used in a distributed setting with no HA guarantees. Additionally, it introduces a common base class which is also used by the EmbeddedHaServices. This base class instantiates the standalone variants of the checkpoint recovery factory, submitted job graphs store, running jobs registry and blob store. The StandaloneHaServices are instantiated with a fixed address for the Job- and ResourceManager. This address and the HighAvailability.DEFAULT_LEADER_ID is returned by the corresponding LeaderRetrievalServices when being started.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user tillrohrmann commented on the issue:

          https://github.com/apache/flink/pull/3622

          Rebased onto the latest `master`.

          Show
          githubbot ASF GitHub Bot added a comment - Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/3622 Rebased onto the latest `master`.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/flink/pull/3622

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3622
          Hide
          till.rohrmann Till Rohrmann added a comment -

          Fixed via a0bb99c70703f6eaf0953b9ea6e70c5dbb9c1c77

          Show
          till.rohrmann Till Rohrmann added a comment - Fixed via a0bb99c70703f6eaf0953b9ea6e70c5dbb9c1c77

            People

            • Assignee:
              till.rohrmann Till Rohrmann
              Reporter:
              till.rohrmann Till Rohrmann
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development