Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.3.0, 1.2.1
    • Component/s: Build System
    • Labels:
      None

      Description

      I think I made a mistake in https://issues.apache.org/jira/browse/FLINK-6122.

      I tried to copy what's in the homepage of https://github.com/apache/incubator-airflow , but it's broken now and looks like they have some different config in Travis. Need to fix this problem.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user bowenli86 opened a pull request:

          https://github.com/apache/flink/pull/3577

          FLINK-6133 fix build status in README.md

          So sorry, I think I made a mistake when committing code for https://issues.apache.org/jira/browse/FLINK-6122.

          I tried to copy what's in the homepage of https://github.com/apache/incubator-airflow , but it's broken now and looks like they have some different config in Travis. Need to fix this problem ASAP.

          Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.

          If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
          In addition to going through the list, please provide a meaningful description of your changes.

          • [x] General
          • The pull request references the related JIRA issue ("FLINK-6133 fix build status in README.md")
          • The pull request addresses only one issue
          • Each commit in the PR has a meaningful commit message (including the JIRA id)
          • [x] Documentation
          • Documentation has been added for new functionality
          • Old documentation affected by the pull request has been updated
          • JavaDoc for public methods has been added
          • [ ] Tests & Build
          • Functionality added by the pull request is covered by tests
          • `mvn clean verify` has been executed successfully locally or a Travis build has passed

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/bowenli86/flink FLINK-6133

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/flink/pull/3577.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #3577


          commit b9079bc13bfeaafc3e7cd862c2c67848cb908f75
          Author: Bowen Li <bowenli86@gmail.com>
          Date: 2017-03-20T16:55:40Z

          FLINK-6133 fix build status in README.md


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user bowenli86 opened a pull request: https://github.com/apache/flink/pull/3577 FLINK-6133 fix build status in README.md So sorry, I think I made a mistake when committing code for https://issues.apache.org/jira/browse/FLINK-6122 . I tried to copy what's in the homepage of https://github.com/apache/incubator-airflow , but it's broken now and looks like they have some different config in Travis. Need to fix this problem ASAP. Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration. If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide] ( http://flink.apache.org/how-to-contribute.html ). In addition to going through the list, please provide a meaningful description of your changes. [x] General The pull request references the related JIRA issue (" FLINK-6133 fix build status in README.md") The pull request addresses only one issue Each commit in the PR has a meaningful commit message (including the JIRA id) [x] Documentation Documentation has been added for new functionality Old documentation affected by the pull request has been updated JavaDoc for public methods has been added [ ] Tests & Build Functionality added by the pull request is covered by tests `mvn clean verify` has been executed successfully locally or a Travis build has passed You can merge this pull request into a Git repository by running: $ git pull https://github.com/bowenli86/flink FLINK-6133 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/3577.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3577 commit b9079bc13bfeaafc3e7cd862c2c67848cb908f75 Author: Bowen Li <bowenli86@gmail.com> Date: 2017-03-20T16:55:40Z FLINK-6133 fix build status in README.md
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user uce commented on the issue:

          https://github.com/apache/flink/pull/3577

          There is a discussion on the dev mailing list whether we want to have this or not. I would wait until that is resolved before continuing here.

          Show
          githubbot ASF GitHub Bot added a comment - Github user uce commented on the issue: https://github.com/apache/flink/pull/3577 There is a discussion on the dev mailing list whether we want to have this or not. I would wait until that is resolved before continuing here.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/flink/pull/3577

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3577

            People

            • Assignee:
              phoenixjiangnan Bowen Li
              Reporter:
              phoenixjiangnan Bowen Li
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development