Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-6122

add TravisCI build status to README.md

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Implemented
    • Affects Version/s: 1.2.0
    • Fix Version/s: 1.3.0
    • Component/s: Build System
    • Labels:
      None

      Description

      Add TravisCI build status to README in github repo. Expectation is to have something like https://github.com/apache/incubator-airflow

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user bowenli86 opened a pull request:

          https://github.com/apache/flink/pull/3570

          FLINK-6122 add TravisCI build status to README.md

          Add TravisCI build status image to FLINK's github repo homepage

          <img width="643" alt="screen shot 2017-03-20 at 12 37 23 am" src="https://cloud.githubusercontent.com/assets/1892692/24091460/6b6e26b4-0d05-11e7-81f9-efca8f08b56e.png">

          Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
          If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
          In addition to going through the list, please provide a meaningful description of your changes.

          • [x] General
          • The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
          • The pull request addresses only one issue
          • Each commit in the PR has a meaningful commit message (including the JIRA id)
          • [x] Documentation
          • Documentation has been added for new functionality
          • Old documentation affected by the pull request has been updated
          • JavaDoc for public methods has been added
          • [x] Tests & Build
          • Functionality added by the pull request is covered by tests
          • `mvn clean verify` has been executed successfully locally or a Travis build has passed

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/bowenli86/flink FLINK-6122

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/flink/pull/3570.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #3570


          commit da54227e51dd224ae9ecccc7d016606a5876595d
          Author: Bowen Li <bowenli86@gmail.com>
          Date: 2017-03-20T07:36:21Z

          FLINK-6122 add TravisCI build status to README.md


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user bowenli86 opened a pull request: https://github.com/apache/flink/pull/3570 FLINK-6122 add TravisCI build status to README.md Add TravisCI build status image to FLINK's github repo homepage <img width="643" alt="screen shot 2017-03-20 at 12 37 23 am" src="https://cloud.githubusercontent.com/assets/1892692/24091460/6b6e26b4-0d05-11e7-81f9-efca8f08b56e.png"> Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration. If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide] ( http://flink.apache.org/how-to-contribute.html ). In addition to going through the list, please provide a meaningful description of your changes. [x] General The pull request references the related JIRA issue (" [FLINK-XXX] Jira title text") The pull request addresses only one issue Each commit in the PR has a meaningful commit message (including the JIRA id) [x] Documentation Documentation has been added for new functionality Old documentation affected by the pull request has been updated JavaDoc for public methods has been added [x] Tests & Build Functionality added by the pull request is covered by tests `mvn clean verify` has been executed successfully locally or a Travis build has passed You can merge this pull request into a Git repository by running: $ git pull https://github.com/bowenli86/flink FLINK-6122 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/3570.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3570 commit da54227e51dd224ae9ecccc7d016606a5876595d Author: Bowen Li <bowenli86@gmail.com> Date: 2017-03-20T07:36:21Z FLINK-6122 add TravisCI build status to README.md
          Hide
          rmetzger Robert Metzger added a comment -

          I'm not sure if we want to merge this change. We once had the travis build status badge in our readme, but decided to remove it, because it often shows "Build failed" due to travis issues etc.
          This gives people the impression that our builds are very unstable .

          Show
          rmetzger Robert Metzger added a comment - I'm not sure if we want to merge this change. We once had the travis build status badge in our readme, but decided to remove it, because it often shows "Build failed" due to travis issues etc. This gives people the impression that our builds are very unstable .
          Hide
          uce Ufuk Celebi added a comment -

          Implemented in 486f724 (master).

          Show
          uce Ufuk Celebi added a comment - Implemented in 486f724 (master).
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/flink/pull/3570

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3570
          Hide
          StephanEwen Stephan Ewen added a comment -

          I am with Robert here. In fact, many builds are marked as "failed" these days simply due to exceeding the 50 minute limit in one profile.
          The status kind of makes the project look bad without a reason.

          We have quasi never a broken master, and currently not even flaky tests
          For a code base of that size, that's a remarkable job by the community, I think
          Would be a pity if this is reflected differently to the works for reasons of timeouts and build infrastructure issues.

          I am +1 for removing the tag.

          Show
          StephanEwen Stephan Ewen added a comment - I am with Robert here. In fact, many builds are marked as "failed" these days simply due to exceeding the 50 minute limit in one profile. The status kind of makes the project look bad without a reason. We have quasi never a broken master, and currently not even flaky tests For a code base of that size, that's a remarkable job by the community, I think Would be a pity if this is reflected differently to the works for reasons of timeouts and build infrastructure issues. I am +1 for removing the tag.

            People

            • Assignee:
              phoenixjiangnan Bowen Li
              Reporter:
              phoenixjiangnan Bowen Li
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development