Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-6104

Resource leak in ListViaRangeSpeedMiniBenchmark

    Details

      Description

          final WriteOptions write_options = new WriteOptions()
              .setSync(false)
              .setDisableWAL(true);
      

      WriteOptions ultimately extends AbstractNativeReference where:

      public abstract class AbstractNativeReference implements AutoCloseable {
      

      WriteOptions instance should be closed.

          final RocksDB rocksDB = RocksDB.open(options, rocksDir.getAbsolutePath());
      

      RocksDB should be closed as well.

        Issue Links

          Activity

          Hide
          mingleizhang mingleizhang added a comment -

          I will give a pr to this jira soon.

          Show
          mingleizhang mingleizhang added a comment - I will give a pr to this jira soon.
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user zhangminglei opened a pull request:

          https://github.com/apache/flink/pull/3725

          FLINK-6104 Fix resource leak in ListViaRangeSpeedMiniBenchmark.

          Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
          If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
          In addition to going through the list, please provide a meaningful description of your changes.

          • [ ] General
          • The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
          • The pull request addresses only one issue
          • Each commit in the PR has a meaningful commit message (including the JIRA id)
          • [ ] Documentation
          • Documentation has been added for new functionality
          • Old documentation affected by the pull request has been updated
          • JavaDoc for public methods has been added
          • [ ] Tests & Build
          • Functionality added by the pull request is covered by tests
          • `mvn clean verify` has been executed successfully locally or a Travis build has passed

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/zhangminglei/flink flink-6104

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/flink/pull/3725.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #3725


          commit 0ff43539f76ec7f87b45fba6e27541487a37c78e
          Author: zhangminglei <zml13856086071@163.com>
          Date: 2017-04-16T12:10:21Z

          FLINK-6104 Fix resource leak in ListViaRangeSpeedMiniBenchmark.


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user zhangminglei opened a pull request: https://github.com/apache/flink/pull/3725 FLINK-6104 Fix resource leak in ListViaRangeSpeedMiniBenchmark. Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration. If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide] ( http://flink.apache.org/how-to-contribute.html ). In addition to going through the list, please provide a meaningful description of your changes. [ ] General The pull request references the related JIRA issue (" [FLINK-XXX] Jira title text") The pull request addresses only one issue Each commit in the PR has a meaningful commit message (including the JIRA id) [ ] Documentation Documentation has been added for new functionality Old documentation affected by the pull request has been updated JavaDoc for public methods has been added [ ] Tests & Build Functionality added by the pull request is covered by tests `mvn clean verify` has been executed successfully locally or a Travis build has passed You can merge this pull request into a Git repository by running: $ git pull https://github.com/zhangminglei/flink flink-6104 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/3725.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3725 commit 0ff43539f76ec7f87b45fba6e27541487a37c78e Author: zhangminglei <zml13856086071@163.com> Date: 2017-04-16T12:10:21Z FLINK-6104 Fix resource leak in ListViaRangeSpeedMiniBenchmark.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user zentol commented on the issue:

          https://github.com/apache/flink/pull/3725

          hmm....i guess we could do it like this since it is only a benchmark, to keep it simple. Will merge this, in any case it is an improvement.

          Show
          githubbot ASF GitHub Bot added a comment - Github user zentol commented on the issue: https://github.com/apache/flink/pull/3725 hmm....i guess we could do it like this since it is only a benchmark, to keep it simple. Will merge this, in any case it is an improvement.
          Hide
          Zentol Chesnay Schepler added a comment -

          1.3: 5e6ffbc19e83529bb6e3c39d4a0b5ab322aa4633

          Show
          Zentol Chesnay Schepler added a comment - 1.3: 5e6ffbc19e83529bb6e3c39d4a0b5ab322aa4633
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/flink/pull/3725

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3725

            People

            • Assignee:
              mingleizhang mingleizhang
              Reporter:
              yuzhihong@gmail.com Ted Yu
            • Votes:
              1 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development