Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-6080

Unclosed ObjectOutputStream in NFA#serialize()

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.3.0
    • Component/s: CEP
    • Labels:
      None

      Description

          public void serialize(NFA<T> record, DataOutputView target) throws IOException {
            ObjectOutputStream oos = new ObjectOutputStream(new DataOutputViewStream(target));
            oos.writeObject(record);
            oos.flush();
          }
      

      ObjectOutputStream should be closed before returning from method.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user dawidwys closed the pull request at:

          https://github.com/apache/flink/pull/3584

          Show
          githubbot ASF GitHub Bot added a comment - Github user dawidwys closed the pull request at: https://github.com/apache/flink/pull/3584
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user kl0u commented on the issue:

          https://github.com/apache/flink/pull/3584

          Hi @dawidwys, I merged this. Can you close this PR and the related JIRA?

          Show
          githubbot ASF GitHub Bot added a comment - Github user kl0u commented on the issue: https://github.com/apache/flink/pull/3584 Hi @dawidwys, I merged this. Can you close this PR and the related JIRA?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user kl0u commented on the issue:

          https://github.com/apache/flink/pull/3584

          LGTM! Merging this...

          Show
          githubbot ASF GitHub Bot added a comment - Github user kl0u commented on the issue: https://github.com/apache/flink/pull/3584 LGTM! Merging this...
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user dawidwys opened a pull request:

          https://github.com/apache/flink/pull/3584

          FLINK-6080 Unclosed ObjectOutputStream in NFA#serialize()

          Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
          If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
          In addition to going through the list, please provide a meaningful description of your changes.

          • [ ] General
          • The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
          • The pull request addresses only one issue
          • Each commit in the PR has a meaningful commit message (including the JIRA id)
          • [ ] Documentation
          • Documentation has been added for new functionality
          • Old documentation affected by the pull request has been updated
          • JavaDoc for public methods has been added
          • [ ] Tests & Build
          • Functionality added by the pull request is covered by tests
          • `mvn clean verify` has been executed successfully locally or a Travis build has passed

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/dawidwys/flink flink6080

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/flink/pull/3584.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #3584


          commit 9ac446aa595d5940cb2a7a6fc262796ff9f0d718
          Author: Dawid Wysakowicz <dawid@getindata.com>
          Date: 2017-03-21T11:06:42Z

          FLINK-6080 Unclosed ObjectOutputStream in NFA#serialize()


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user dawidwys opened a pull request: https://github.com/apache/flink/pull/3584 FLINK-6080 Unclosed ObjectOutputStream in NFA#serialize() Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration. If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide] ( http://flink.apache.org/how-to-contribute.html ). In addition to going through the list, please provide a meaningful description of your changes. [ ] General The pull request references the related JIRA issue (" [FLINK-XXX] Jira title text") The pull request addresses only one issue Each commit in the PR has a meaningful commit message (including the JIRA id) [ ] Documentation Documentation has been added for new functionality Old documentation affected by the pull request has been updated JavaDoc for public methods has been added [ ] Tests & Build Functionality added by the pull request is covered by tests `mvn clean verify` has been executed successfully locally or a Travis build has passed You can merge this pull request into a Git repository by running: $ git pull https://github.com/dawidwys/flink flink6080 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/3584.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3584 commit 9ac446aa595d5940cb2a7a6fc262796ff9f0d718 Author: Dawid Wysakowicz <dawid@getindata.com> Date: 2017-03-21T11:06:42Z FLINK-6080 Unclosed ObjectOutputStream in NFA#serialize()

            People

            • Assignee:
              dawidwys Dawid Wysakowicz
              Reporter:
              yuzhihong@gmail.com Ted Yu
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development