[FLINK-6079] Ineffective null check in FlinkKafkaConsumerBase#open()

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 1.3.0
• Component/s: Connectors / Kafka
• Assignee: Chesnay Schepler
• Reporter: Ted Yu
• Created: 16/Mar/17 14:58
• Updated: 06/Apr/17 17:38
• Resolved: 06/Apr/17 17:38

Description

Here is related code:

    List<KafkaTopicPartition> kafkaTopicPartitions = getKafkaPartitions(topics);

    subscribedPartitionsToStartOffsets = new HashMap<>(kafkaTopicPartitions.size());

    if (kafkaTopicPartitions != null) {

Prior to the null check, kafkaTopicPartitions is already dereferenced.

Issue Links

• links to: GitHub Pull Request #3685