Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-6056

apache-rat exclude flink directory in tools

    Details

    • Type: Wish
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.3.0
    • Component/s: Build System
    • Labels:
      None

      Description

      The flink* directory in the tools is temporary cloned when build distribution.
      So when build the Flink project, we should exclude the flink* directory.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user shijinkui opened a pull request:

          https://github.com/apache/flink/pull/3540

          FLINK-6056 apache-rat exclude flink directory in tools

          The flink* directory in the tools is temporary cloned when build distribution.
          So when build the Flink project, we should exclude the flink* directory.

          • [X] General
          • The pull request references the related JIRA issue ("FLINK-6056 apache-rat exclude flink directory in tools")
          • The pull request addresses only one issue
          • Each commit in the PR has a meaningful commit message (including the JIRA id)
          • [X] Documentation
          • Documentation has been added for new functionality
          • Old documentation affected by the pull request has been updated
          • JavaDoc for public methods has been added
          • [X] Tests & Build
          • Functionality added by the pull request is covered by tests
          • `mvn clean verify` has been executed successfully locally or a Travis build has passed

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/hwstreaming/flink FLINK-6056

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/flink/pull/3540.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #3540


          commit ccdd802b333555a36b415dbe1289d04a6470f075
          Author: Jinkui Shi <shijinkui@huawei.com>
          Date: 2017-03-15T08:05:20Z

          FLINK-6056 apache-rat exclude flink directory in tools


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user shijinkui opened a pull request: https://github.com/apache/flink/pull/3540 FLINK-6056 apache-rat exclude flink directory in tools The flink* directory in the tools is temporary cloned when build distribution. So when build the Flink project, we should exclude the flink* directory. [X] General The pull request references the related JIRA issue (" FLINK-6056 apache-rat exclude flink directory in tools") The pull request addresses only one issue Each commit in the PR has a meaningful commit message (including the JIRA id) [X] Documentation Documentation has been added for new functionality Old documentation affected by the pull request has been updated JavaDoc for public methods has been added [X] Tests & Build Functionality added by the pull request is covered by tests `mvn clean verify` has been executed successfully locally or a Travis build has passed You can merge this pull request into a Git repository by running: $ git pull https://github.com/hwstreaming/flink FLINK-6056 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/3540.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3540 commit ccdd802b333555a36b415dbe1289d04a6470f075 Author: Jinkui Shi <shijinkui@huawei.com> Date: 2017-03-15T08:05:20Z FLINK-6056 apache-rat exclude flink directory in tools
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user zentol commented on the issue:

          https://github.com/apache/flink/pull/3540

          Why exactly is it a problem if the rat-plugin checks the tools directory?

          Show
          githubbot ASF GitHub Bot added a comment - Github user zentol commented on the issue: https://github.com/apache/flink/pull/3540 Why exactly is it a problem if the rat-plugin checks the tools directory?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user shijinkui commented on the issue:

          https://github.com/apache/flink/pull/3540

          > Why exactly is it a problem if the rat-plugin checks the tools directory?
          There no necessary to check the tmp flink project in the tools, because it will extra cost some time when build the main project.

          Show
          githubbot ASF GitHub Bot added a comment - Github user shijinkui commented on the issue: https://github.com/apache/flink/pull/3540 > Why exactly is it a problem if the rat-plugin checks the tools directory? There no necessary to check the tmp flink project in the tools, because it will extra cost some time when build the main project.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user StephanEwen commented on the issue:

          https://github.com/apache/flink/pull/3540

          I am a bit confused... I think there is no `tools/flink*` directory that would need an exclusion...

          Show
          githubbot ASF GitHub Bot added a comment - Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3540 I am a bit confused... I think there is no `tools/flink*` directory that would need an exclusion...
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user shijinkui commented on the issue:

          https://github.com/apache/flink/pull/3540

          > I am a bit confused... I think there is no tools/flink* directory that would need an exclusion...

          When execute `tools/create_release_files.sh`, it will clone flink project from apache. Also we had add `tools/flink*` in the .gitignore

          Show
          githubbot ASF GitHub Bot added a comment - Github user shijinkui commented on the issue: https://github.com/apache/flink/pull/3540 > I am a bit confused... I think there is no tools/flink* directory that would need an exclusion... When execute `tools/create_release_files.sh`, it will clone flink project from apache. Also we had add `tools/flink*` in the .gitignore
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user StephanEwen commented on the issue:

          https://github.com/apache/flink/pull/3540

          @shijinkui Got it, thanks.

          +1 to merge this

          Show
          githubbot ASF GitHub Bot added a comment - Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3540 @shijinkui Got it, thanks. +1 to merge this
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user StephanEwen commented on the issue:

          https://github.com/apache/flink/pull/3540

          Merging this...

          Show
          githubbot ASF GitHub Bot added a comment - Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3540 Merging this...
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/flink/pull/3540

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3540
          Hide
          StephanEwen Stephan Ewen added a comment -

          Fixed in 1.3.0 via 96ec65592ca0c1f4da144a2fd8f418a05aff488a

          Show
          StephanEwen Stephan Ewen added a comment - Fixed in 1.3.0 via 96ec65592ca0c1f4da144a2fd8f418a05aff488a

            People

            • Assignee:
              Unassigned
              Reporter:
              Jinkui Shi jinkuishi
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development