Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-6005

unit test ArrayList initializations without initial size

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.3.0
    • Fix Version/s: 1.3.0
    • Component/s: Tests
    • Labels:
      None

      Description

      I found some ArrayList initializations without a sensible initial size although it is possible to select one. The following PR will show some cases that I'd like to fix.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user NicoK opened a pull request:

          https://github.com/apache/flink/pull/3499

          FLINK-6005 fix some ArrayList initializations without initial size

          This is just to give some ArrayList initializations an initial size value to reduce tests overhead.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/NicoK/flink flink-6005

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/flink/pull/3499.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #3499


          commit 7935d4e1ede6b831b88b5fc3e5d0b2fe161c7bed
          Author: Nico Kruber <nico@data-artisans.com>
          Date: 2017-03-09T11:24:33Z

          FLINK-6005 fix some ArrayList initializations without initial size


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user NicoK opened a pull request: https://github.com/apache/flink/pull/3499 FLINK-6005 fix some ArrayList initializations without initial size This is just to give some ArrayList initializations an initial size value to reduce tests overhead. You can merge this pull request into a Git repository by running: $ git pull https://github.com/NicoK/flink flink-6005 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/3499.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3499 commit 7935d4e1ede6b831b88b5fc3e5d0b2fe161c7bed Author: Nico Kruber <nico@data-artisans.com> Date: 2017-03-09T11:24:33Z FLINK-6005 fix some ArrayList initializations without initial size
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user StephanEwen commented on the issue:

          https://github.com/apache/flink/pull/3499

          Looks good, merging...

          Show
          githubbot ASF GitHub Bot added a comment - Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3499 Looks good, merging...
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/flink/pull/3499

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3499
          Hide
          StephanEwen Stephan Ewen added a comment -

          Fixed via bb1197d9162a630c87d47defc5d0c42de6726feb

          Show
          StephanEwen Stephan Ewen added a comment - Fixed via bb1197d9162a630c87d47defc5d0c42de6726feb

            People

            • Assignee:
              NicoK Nico Kruber
              Reporter:
              NicoK Nico Kruber
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development