Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-6000

Can not start HA cluster with start-cluster.sh

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.2.0
    • Fix Version/s: 1.3.0, 1.2.1
    • Component/s: Startup Shell Scripts
    • Labels:
      None

      Description

      Right know it is impossible to start a cluster in zookeeper HA mode as described in the documentation by setting:

      in con/flink-conf.yaml:

      high-availability: zookeeper
      ...
      

      in conf/masters:

      localhost:8081
      localhost:8082
      

      The problem is with the bin/config.sh file. If value "zookeeper" is read from config file the variable HIGH_AVAILABILITY will be reset to "none" with the else branch. See the below code:

      if [ -z "${HIGH_AVAILABILITY}" ]; then
           HIGH_AVAILABILITY=$(readFromConfig ${KEY_HIGH_AVAILABILITY} "" "${YAML_CONF}")
           if [ -z "${HIGH_AVAILABILITY}" ]; then
              # Try deprecated value
              DEPRECATED_HA=$(readFromConfig "recovery.mode" "" "${YAML_CONF}")
              if [ -z "${DEPRECATED_HA}" ]; then
                  HIGH_AVAILABILITY="none"
              elif [ ${DEPRECATED_HA} == "standalone" ]; then
                  # Standalone is now 'none'
                  HIGH_AVAILABILITY="none"
              else
                  HIGH_AVAILABILITY=${DEPRECATED_HA}
              fi
           else
               HIGH_AVAILABILITY="none" <-- it exits here
           fi
      fi
      

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user dawidwys opened a pull request:

          https://github.com/apache/flink/pull/3506

          FLINK-6000 Fix starting HA cluster with start-cluster.sh

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/dawidwys/flink flink6000

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/flink/pull/3506.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #3506


          commit 1b94be9d77a784012aab852bc4e51bff1c793009
          Author: Dawid Wysakowicz <dawid@getindata.com>
          Date: 2017-03-10T08:15:06Z

          FLINK-6000 Fix starting HA cluster with start-cluster.sh


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user dawidwys opened a pull request: https://github.com/apache/flink/pull/3506 FLINK-6000 Fix starting HA cluster with start-cluster.sh You can merge this pull request into a Git repository by running: $ git pull https://github.com/dawidwys/flink flink6000 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/3506.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3506 commit 1b94be9d77a784012aab852bc4e51bff1c793009 Author: Dawid Wysakowicz <dawid@getindata.com> Date: 2017-03-10T08:15:06Z FLINK-6000 Fix starting HA cluster with start-cluster.sh
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user dawidwys commented on the issue:

          https://github.com/apache/flink/pull/3506

          @uce You replied to my message on mailing-list than maybe you could have a look at this PR
          Recently another user reported it at SO: http://stackoverflow.com/questions/42793598/flink-1-2-does-not-start-in-ha-cluster-mode

          Show
          githubbot ASF GitHub Bot added a comment - Github user dawidwys commented on the issue: https://github.com/apache/flink/pull/3506 @uce You replied to my message on mailing-list than maybe you could have a look at this PR Recently another user reported it at SO: http://stackoverflow.com/questions/42793598/flink-1-2-does-not-start-in-ha-cluster-mode
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user StephanEwen commented on the issue:

          https://github.com/apache/flink/pull/3506

          Good change, merging this for `1.2.1` and `1.3`.

          Show
          githubbot ASF GitHub Bot added a comment - Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3506 Good change, merging this for `1.2.1` and `1.3`.
          Hide
          StephanEwen Stephan Ewen added a comment -

          Fixed in

          • 1.2.1 via d398205edbdf1e76569e6508be1066243e7b1101
          • 1.3.0 via 034d9a3ab8bb7dec57a7021564060274760ed339
          Show
          StephanEwen Stephan Ewen added a comment - Fixed in 1.2.1 via d398205edbdf1e76569e6508be1066243e7b1101 1.3.0 via 034d9a3ab8bb7dec57a7021564060274760ed339
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/flink/pull/3506

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3506

            People

            • Assignee:
              dawidwys Dawid Wysakowicz
              Reporter:
              dawidwys Dawid Wysakowicz
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development