Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-5977

Rename MAX_ATTEMPTS_HISTORY_SIZE key

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 1.3.0
    • Fix Version/s: 1.3.0
    • Component/s: JobManager
    • Labels:
      None

      Description

      The JobManagerOptions#MAX_ATTEMPTS_HISTORY_SIZE key is inconsistent with other jobmanager related keys in that it starts with "job-manager" instead of "jobmanager".

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user fanyon opened a pull request:

          https://github.com/apache/flink/pull/3592

          FLINK-5977 Rename MAX_ATTEMPTS_HISTORY_SIZE key

          FLINK-5977 Rename MAX_ATTEMPTS_HISTORY_SIZE key

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/fanyon/flink FLINK-5977

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/flink/pull/3592.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #3592


          commit 3bbcedaba117a0f7319ab9676fa93af04f8f41c8
          Author: mengji.fy <mengji.fy@taobao.com>
          Date: 2017-03-22T08:19:44Z

          FLINK-5977 Rename MAX_ATTEMPTS_HISTORY_SIZE key


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user fanyon opened a pull request: https://github.com/apache/flink/pull/3592 FLINK-5977 Rename MAX_ATTEMPTS_HISTORY_SIZE key FLINK-5977 Rename MAX_ATTEMPTS_HISTORY_SIZE key You can merge this pull request into a Git repository by running: $ git pull https://github.com/fanyon/flink FLINK-5977 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/3592.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3592 commit 3bbcedaba117a0f7319ab9676fa93af04f8f41c8 Author: mengji.fy <mengji.fy@taobao.com> Date: 2017-03-22T08:19:44Z FLINK-5977 Rename MAX_ATTEMPTS_HISTORY_SIZE key
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user StephanEwen commented on the issue:

          https://github.com/apache/flink/pull/3592

          Thanks for the pull request.
          This has actually already been fixed in https://github.com/apache/flink/commit/81a143f6b42cf39d56a36222d14b5db0cc54addb

          The commit also retains the old key as a deprecated parameter for backwards compatibility.

          Show
          githubbot ASF GitHub Bot added a comment - Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3592 Thanks for the pull request. This has actually already been fixed in https://github.com/apache/flink/commit/81a143f6b42cf39d56a36222d14b5db0cc54addb The commit also retains the old key as a deprecated parameter for backwards compatibility.
          Hide
          Zentol Chesnay Schepler added a comment -

          Fixed in 81a143f6b42cf39d56a36222d14b5db0cc54addb.

          Show
          Zentol Chesnay Schepler added a comment - Fixed in 81a143f6b42cf39d56a36222d14b5db0cc54addb.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/flink/pull/3592

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3592

            People

            • Assignee:
              StephanEwen Stephan Ewen
              Reporter:
              Zentol Chesnay Schepler
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development