Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-5954

Always assign names to the window in the Stream SQL API

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Implemented
    • Affects Version/s: None
    • Fix Version/s: 1.3.0
    • Component/s: None
    • Labels:
      None

      Description

      CALCITE-1603 and CALCITE-1615 brings in supports for TUMBLE, HOP, SESSION grouped windows, as well as the corresponding auxiliary functions that allow uses to query the start and the end of the windows (e.g., TUMBLE_START() and TUMBLE_END() see http://calcite.apache.org/docs/stream.html for more details).

      The goal of this jira is to add support for these auxiliary functions in Flink. Flink already has runtime supports for them, as these functions are essential mapped to the WindowStart and WindowEnd classes.

      To implement this feature in transformation, the transformation needs to recognize these functions and map them to the WindowStart and WindowEnd classes.

      The problem is that both classes can only refer to the windows using alias. Therefore this jira proposes to assign a unique name for each window to enable the transformation.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user haohui opened a pull request:

          https://github.com/apache/flink/pull/3461

          FLINK-5954 Always assign names to the window in the Stream SQL API.

          Please see jira for more details.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/haohui/flink FLINK-5954

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/flink/pull/3461.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #3461


          commit 93ace85d026959dce9332085eeb750fa9f50ce52
          Author: Haohui Mai <wheat9@apache.org>
          Date: 2017-03-03T01:44:43Z

          FLINK-5954 Always assign names to the window in the Stream SQL API.


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user haohui opened a pull request: https://github.com/apache/flink/pull/3461 FLINK-5954 Always assign names to the window in the Stream SQL API. Please see jira for more details. You can merge this pull request into a Git repository by running: $ git pull https://github.com/haohui/flink FLINK-5954 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/3461.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3461 commit 93ace85d026959dce9332085eeb750fa9f50ce52 Author: Haohui Mai <wheat9@apache.org> Date: 2017-03-03T01:44:43Z FLINK-5954 Always assign names to the window in the Stream SQL API.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user sunjincheng121 commented on the issue:

          https://github.com/apache/flink/pull/3461

          HI, @haohu thanks for your contribution!
          Can you tell me why we need this change? and can you add simple unit test ?

          Best,
          SunJincheng

          Show
          githubbot ASF GitHub Bot added a comment - Github user sunjincheng121 commented on the issue: https://github.com/apache/flink/pull/3461 HI, @haohu thanks for your contribution! Can you tell me why we need this change? and can you add simple unit test ? Best, SunJincheng
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user haohui closed the pull request at:

          https://github.com/apache/flink/pull/3461

          Show
          githubbot ASF GitHub Bot added a comment - Github user haohui closed the pull request at: https://github.com/apache/flink/pull/3461
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user haohui commented on the issue:

          https://github.com/apache/flink/pull/3461

          Sorry for the late response. This is a prerequisite step for FLINK-6012 – translating the group auxiliary functions (e.g., `TUMBLE_START`) to the corresponding Flink expressions (e.g., `WindowStart`).

          A more detailed description is on the FLINK-5954.

          Show
          githubbot ASF GitHub Bot added a comment - Github user haohui commented on the issue: https://github.com/apache/flink/pull/3461 Sorry for the late response. This is a prerequisite step for FLINK-6012 – translating the group auxiliary functions (e.g., `TUMBLE_START`) to the corresponding Flink expressions (e.g., `WindowStart`). A more detailed description is on the FLINK-5954 .
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user haohui reopened a pull request:

          https://github.com/apache/flink/pull/3461

          FLINK-5954 Always assign names to the window in the Stream SQL API.

          Please see jira for more details.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/haohui/flink FLINK-5954

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/flink/pull/3461.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #3461


          commit 064b827127b15a1397c216aae6611d575a75556b
          Author: Haohui Mai <wheat9@apache.org>
          Date: 2017-03-09T21:57:49Z

          FLINK-5954 Always assign names to the window in the Stream SQL API.


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user haohui reopened a pull request: https://github.com/apache/flink/pull/3461 FLINK-5954 Always assign names to the window in the Stream SQL API. Please see jira for more details. You can merge this pull request into a Git repository by running: $ git pull https://github.com/haohui/flink FLINK-5954 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/3461.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3461 commit 064b827127b15a1397c216aae6611d575a75556b Author: Haohui Mai <wheat9@apache.org> Date: 2017-03-09T21:57:49Z FLINK-5954 Always assign names to the window in the Stream SQL API.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user sunjincheng121 commented on the issue:

          https://github.com/apache/flink/pull/3461

          Hi, @haohui Thanks for your explanation, and I'll see the detail in the FLINK-5954.
          Thanks,
          SunJincheng

          Show
          githubbot ASF GitHub Bot added a comment - Github user sunjincheng121 commented on the issue: https://github.com/apache/flink/pull/3461 Hi, @haohui Thanks for your explanation, and I'll see the detail in the FLINK-5954 . Thanks, SunJincheng
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user fhueske commented on the issue:

          https://github.com/apache/flink/pull/3461

          Thanks for the PR @haohui.
          Looks good to me. +1 to merge

          Show
          githubbot ASF GitHub Bot added a comment - Github user fhueske commented on the issue: https://github.com/apache/flink/pull/3461 Thanks for the PR @haohui. Looks good to me. +1 to merge
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/flink/pull/3461

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3461
          Hide
          fhueske Fabian Hueske added a comment -

          Implemented with 7ef068ccc9552799cb9f2bd648782c636d2df2db

          Show
          fhueske Fabian Hueske added a comment - Implemented with 7ef068ccc9552799cb9f2bd648782c636d2df2db

            People

            • Assignee:
              wheat9 Haohui Mai
              Reporter:
              wheat9 Haohui Mai
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development