Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-5952

JobCancellationWithSavepointHandlersTest uses deprecated JsonNode#getValuesAsText

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 1.3.0
    • Fix Version/s: 1.3.0
    • Component/s: Tests, Webfrontend
    • Labels:
      None

      Description

      Usage of JsonNode#getValuesAsText() should be replaced with JsonNode#asText().

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user mtunique opened a pull request:

          https://github.com/apache/flink/pull/3463

          FLINK-5952 JobCancellationWithSavepointHandlersTest uses deprecated JsonNode#getValuesAsText

          Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
          If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
          In addition to going through the list, please provide a meaningful description of your changes.

          • [x] General
          • The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
          • The pull request addresses only one issue
          • Each commit in the PR has a meaningful commit message (including the JIRA id)
          • [ ] Documentation
          • Documentation has been added for new functionality
          • Old documentation affected by the pull request has been updated
          • JavaDoc for public methods has been added
          • [x] Tests & Build
          • Functionality added by the pull request is covered by tests
          • `mvn clean verify` has been executed successfully locally or a Travis build has passed

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/mtunique/flink FLINK-5952

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/flink/pull/3463.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #3463


          commit d73d108ae9f8013aa541fb49b0b2d3d8ee7c3ae5
          Author: mtunique <oatgnem@gmail.com>
          Date: 2017-03-03T03:37:51Z

          FLINK-5952 JobCancellationWithSavepointHandlersTest uses deprecated JsonNode#getValuesAsText


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user mtunique opened a pull request: https://github.com/apache/flink/pull/3463 FLINK-5952 JobCancellationWithSavepointHandlersTest uses deprecated JsonNode#getValuesAsText Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration. If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide] ( http://flink.apache.org/how-to-contribute.html ). In addition to going through the list, please provide a meaningful description of your changes. [x] General The pull request references the related JIRA issue (" [FLINK-XXX] Jira title text") The pull request addresses only one issue Each commit in the PR has a meaningful commit message (including the JIRA id) [ ] Documentation Documentation has been added for new functionality Old documentation affected by the pull request has been updated JavaDoc for public methods has been added [x] Tests & Build Functionality added by the pull request is covered by tests `mvn clean verify` has been executed successfully locally or a Travis build has passed You can merge this pull request into a Git repository by running: $ git pull https://github.com/mtunique/flink FLINK-5952 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/3463.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3463 commit d73d108ae9f8013aa541fb49b0b2d3d8ee7c3ae5 Author: mtunique <oatgnem@gmail.com> Date: 2017-03-03T03:37:51Z FLINK-5952 JobCancellationWithSavepointHandlersTest uses deprecated JsonNode#getValuesAsText
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user mtunique closed the pull request at:

          https://github.com/apache/flink/pull/3463

          Show
          githubbot ASF GitHub Bot added a comment - Github user mtunique closed the pull request at: https://github.com/apache/flink/pull/3463
          Hide
          StephanEwen Stephan Ewen added a comment -

          Fixed via 3cad30974e3bf16d1604096f2b0e138768ae795b

          Note: Wrong issue number in commit message.

          Show
          StephanEwen Stephan Ewen added a comment - Fixed via 3cad30974e3bf16d1604096f2b0e138768ae795b Note: Wrong issue number in commit message.

            People

            • Assignee:
              Zentol Chesnay Schepler
              Reporter:
              Zentol Chesnay Schepler
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development