Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-5895

Reduce logging aggressiveness of FileSystemSafetyNet

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.2.0
    • Fix Version/s: 1.3.0, 1.2.1
    • Component/s: Local Runtime
    • Labels:
      None

      Description

      The FileSystemSafetyNet logs on info level every time it is created and destroyed. This causes a log flood from the async checkpoint thread, which starts and stops that safety net very often.

        Activity

        Hide
        StephanEwen Stephan Ewen added a comment -

        This is a good example of why logging inside utility methods is often tricky. It is better to log in the classes that invoke the utilities, because they have the context to see whether and on what level the operation should be logged.

        Show
        StephanEwen Stephan Ewen added a comment - This is a good example of why logging inside utility methods is often tricky. It is better to log in the classes that invoke the utilities, because they have the context to see whether and on what level the operation should be logged.
        Hide
        StephanEwen Stephan Ewen added a comment -

        Fixed in

        • 1.2.1 via 74b29f5a3dc4f1413bbf8addb6b4234a5bfe6581
        • 1.3.0 via f6e6e7ecf4d287f76698302417a9ff2ffc869477
        Show
        StephanEwen Stephan Ewen added a comment - Fixed in 1.2.1 via 74b29f5a3dc4f1413bbf8addb6b4234a5bfe6581 1.3.0 via f6e6e7ecf4d287f76698302417a9ff2ffc869477

          People

          • Assignee:
            StephanEwen Stephan Ewen
            Reporter:
            StephanEwen Stephan Ewen
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development