Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-5877

Fix Scala snippet in Async I/O API doc

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.3.0, 1.2.1
    • Component/s: Documentation
    • Labels:
      None

      Description

      The current `docs/dev/stream/asyncio.md` has an error in the Scala snippet, it doesn't use the Scala AsyncFunction and the brackets are inconsistent.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user alkagin opened a pull request:

          https://github.com/apache/flink/pull/3383

          FLINK-5877 [docs] Fix Scala snippet in Async I/O API doc

          Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
          If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
          In addition to going through the list, please provide a meaningful description of your changes.

          • [ ] General
          • The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
          • The pull request addresses only one issue
          • Each commit in the PR has a meaningful commit message (including the JIRA id)
          • [ ] Documentation
          • Documentation has been added for new functionality
          • Old documentation affected by the pull request has been updated
          • JavaDoc for public methods has been added
          • [ ] Tests & Build
          • Functionality added by the pull request is covered by tests
          • `mvn clean verify` has been executed successfully locally or a Travis build has passed

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/radicalbit/flink FLINK-5877

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/flink/pull/3383.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #3383


          commit 12ae9863ae485ab95c7e599a84e0feba61d279f5
          Author: Andrea Sella <andrea.sella@radicalbit.io>
          Date: 2017-02-21T20:18:16Z

          FLINK-5877 [docs] Fix Async I/O Scala snippet


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user alkagin opened a pull request: https://github.com/apache/flink/pull/3383 FLINK-5877 [docs] Fix Scala snippet in Async I/O API doc Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration. If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide] ( http://flink.apache.org/how-to-contribute.html ). In addition to going through the list, please provide a meaningful description of your changes. [ ] General The pull request references the related JIRA issue (" [FLINK-XXX] Jira title text") The pull request addresses only one issue Each commit in the PR has a meaningful commit message (including the JIRA id) [ ] Documentation Documentation has been added for new functionality Old documentation affected by the pull request has been updated JavaDoc for public methods has been added [ ] Tests & Build Functionality added by the pull request is covered by tests `mvn clean verify` has been executed successfully locally or a Travis build has passed You can merge this pull request into a Git repository by running: $ git pull https://github.com/radicalbit/flink FLINK-5877 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/3383.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3383 commit 12ae9863ae485ab95c7e599a84e0feba61d279f5 Author: Andrea Sella <andrea.sella@radicalbit.io> Date: 2017-02-21T20:18:16Z FLINK-5877 [docs] Fix Async I/O Scala snippet
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/flink/pull/3383

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3383
          Hide
          StephanEwen Stephan Ewen added a comment -

          Fixed in

          • 1.2.1 via b5ec146413bedf55867e15652c7e29f1e4e2d220
          • 1.3.0 via 2d2ffbad9684e879aa92473798701b7cfc0d1277
          Show
          StephanEwen Stephan Ewen added a comment - Fixed in 1.2.1 via b5ec146413bedf55867e15652c7e29f1e4e2d220 1.3.0 via 2d2ffbad9684e879aa92473798701b7cfc0d1277

            People

            • Assignee:
              alkagin Andrea Sella
              Reporter:
              alkagin Andrea Sella
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development