Details

    • Type: Bug
    • Status: Closed
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 1.3.0
    • Fix Version/s: 1.3.0
    • Component/s: Startup Shell Scripts
    • Labels:
      None

      Description

      $ ./bin/jobmanager.sh 
      Unknown daemon ''. Usage: flink-daemon.sh (start|stop|stop-all) (jobmanager|taskmanager|zookeeper) [args].
      

      The arguments in jobmanager.sh's call to flink-daemon.sh are misaligned when $STARTSTOP is the null string.

      "${FLINK_BIN_DIR}"/flink-daemon.sh $STARTSTOP jobmanager "${args[@]}"
      

      Same issue in taskmanager.sh and zookeeper.sh.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user greghogan opened a pull request:

          https://github.com/apache/flink/pull/3352

          FLINK-5838 [scripts] Print shell script usage

          If jobmanager.sh, taskmanager.sh, or zookeeper.sh are called without arguments then argument list for the call to flink-daemon.sh is misaligned and the usage for flink-daemon displayed to the user.

          Adds a check to each script to check for a valid action and otherwise displays the proper usage string.

          Note: this PR conflicts with the PR for FLINK-4326 which adds a "start-foreground" action.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/greghogan/flink 5838_print_shell_script_usage

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/flink/pull/3352.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #3352


          commit 0441164935a34032523040864ec18ee01b4adb5b
          Author: Greg Hogan <code@greghogan.com>
          Date: 2017-02-17T19:38:31Z

          FLINK-5838 [scripts] Print shell script usage

          If jobmanager.sh, taskmanager.sh, or zookeeper.sh are called without
          arguments then argument list for the call to flink-daemon.sh is
          misaligned and the usage for flink-daemon displayed to the user.

          Adds a check to each script to check for a valid action and otherwise
          displays the proper usage string.


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user greghogan opened a pull request: https://github.com/apache/flink/pull/3352 FLINK-5838 [scripts] Print shell script usage If jobmanager.sh, taskmanager.sh, or zookeeper.sh are called without arguments then argument list for the call to flink-daemon.sh is misaligned and the usage for flink-daemon displayed to the user. Adds a check to each script to check for a valid action and otherwise displays the proper usage string. Note: this PR conflicts with the PR for FLINK-4326 which adds a "start-foreground" action. You can merge this pull request into a Git repository by running: $ git pull https://github.com/greghogan/flink 5838_print_shell_script_usage Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/3352.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3352 commit 0441164935a34032523040864ec18ee01b4adb5b Author: Greg Hogan <code@greghogan.com> Date: 2017-02-17T19:38:31Z FLINK-5838 [scripts] Print shell script usage If jobmanager.sh, taskmanager.sh, or zookeeper.sh are called without arguments then argument list for the call to flink-daemon.sh is misaligned and the usage for flink-daemon displayed to the user. Adds a check to each script to check for a valid action and otherwise displays the proper usage string.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user rmetzger commented on the issue:

          https://github.com/apache/flink/pull/3352

          Changes look good in my opinion.

          Show
          githubbot ASF GitHub Bot added a comment - Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/3352 Changes look good in my opinion.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/flink/pull/3352

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3352
          Hide
          greghogan Greg Hogan added a comment -

          Fixed in 3fcc4e37c282a07e09c19934e71c141beefd8073

          Show
          greghogan Greg Hogan added a comment - Fixed in 3fcc4e37c282a07e09c19934e71c141beefd8073

            People

            • Assignee:
              greghogan Greg Hogan
              Reporter:
              greghogan Greg Hogan
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development