Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Implemented
    • Affects Version/s: 1.3.0
    • Fix Version/s: 1.3.0, 1.4.0
    • Component/s: Webfrontend
    • Labels:

      Description

      When displaying individual metrics for a vertex / node of a job in the webui, it is desirable to add an option to display metrics as a numeric or as a chart.

        Issue Links

          Activity

          Hide
          greghogan Greg Hogan added a comment -

          master: 3dd5c991bab9474b40ee20d2b63ac532bffa34f7
          release-1.3: 4882f366686e4c97a3442962ca2e9b5b0f0b8d19

          Show
          greghogan Greg Hogan added a comment - master: 3dd5c991bab9474b40ee20d2b63ac532bffa34f7 release-1.3: 4882f366686e4c97a3442962ca2e9b5b0f0b8d19
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/flink/pull/3367

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3367
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user greghogan commented on the issue:

          https://github.com/apache/flink/pull/3367

          @nellboy thanks for this contribution! Merging ...

          Show
          githubbot ASF GitHub Bot added a comment - Github user greghogan commented on the issue: https://github.com/apache/flink/pull/3367 @nellboy thanks for this contribution! Merging ...
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user greghogan commented on the issue:

          https://github.com/apache/flink/pull/3367

          @nellboy please rebase to master.

          Show
          githubbot ASF GitHub Bot added a comment - Github user greghogan commented on the issue: https://github.com/apache/flink/pull/3367 @nellboy please rebase to master.
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user nellboy opened a pull request:

          https://github.com/apache/flink/pull/3367

          FLINK-5819 [webui] implements numeric option on metrics graphs

          FLINK-5819 [webui] implements numeric option on metrics graphs
          ![pasted image at 2017_02_17 13_56](https://cloud.githubusercontent.com/assets/39847/23135607/937a75da-f799-11e6-9dbb-6e0c877f615b.png)

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/nellboy/flink webui/numeric-metrics

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/flink/pull/3367.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #3367


          commit 3d05e2dfdf0bef516cfdc0e298e37e2583a8187c
          Author: paul <nellboy@gmail.com>
          Date: 2017-02-20T17:20:45Z

          FLINK-5819 [webui] implements numeric option on metrics graphs


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user nellboy opened a pull request: https://github.com/apache/flink/pull/3367 FLINK-5819 [webui] implements numeric option on metrics graphs FLINK-5819 [webui] implements numeric option on metrics graphs ! [pasted image at 2017_02_17 13_56] ( https://cloud.githubusercontent.com/assets/39847/23135607/937a75da-f799-11e6-9dbb-6e0c877f615b.png ) You can merge this pull request into a Git repository by running: $ git pull https://github.com/nellboy/flink webui/numeric-metrics Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/3367.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3367 commit 3d05e2dfdf0bef516cfdc0e298e37e2583a8187c Author: paul <nellboy@gmail.com> Date: 2017-02-20T17:20:45Z FLINK-5819 [webui] implements numeric option on metrics graphs
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user nellboy closed the pull request at:

          https://github.com/apache/flink/pull/3361

          Show
          githubbot ASF GitHub Bot added a comment - Github user nellboy closed the pull request at: https://github.com/apache/flink/pull/3361
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user zentol commented on the issue:

          https://github.com/apache/flink/pull/3361

          ah, ignore my previous comment; that's not relevant to this PR.

          Show
          githubbot ASF GitHub Bot added a comment - Github user zentol commented on the issue: https://github.com/apache/flink/pull/3361 ah, ignore my previous comment; that's not relevant to this PR.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user zentol commented on the issue:

          https://github.com/apache/flink/pull/3361

          How well does this handle long metric names? (100+ characters)

          (You can emulate this by running the SocketWindowWordCount example)

          Show
          githubbot ASF GitHub Bot added a comment - Github user zentol commented on the issue: https://github.com/apache/flink/pull/3361 How well does this handle long metric names? (100+ characters) (You can emulate this by running the SocketWindowWordCount example)
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user nellboy commented on the issue:

          https://github.com/apache/flink/pull/3361

          certainly, my apologies. Please find attached

          ![pasted image at 2017_02_17 13_56](https://cloud.githubusercontent.com/assets/39847/23130481/dc33c384-f786-11e6-85c5-21a8cf6b9f11.png)

          Show
          githubbot ASF GitHub Bot added a comment - Github user nellboy commented on the issue: https://github.com/apache/flink/pull/3361 certainly, my apologies. Please find attached ! [pasted image at 2017_02_17 13_56] ( https://cloud.githubusercontent.com/assets/39847/23130481/dc33c384-f786-11e6-85c5-21a8cf6b9f11.png )
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user zentol commented on the issue:

          https://github.com/apache/flink/pull/3361

          Could you add a screenshot how it would look like after the changes?

          Show
          githubbot ASF GitHub Bot added a comment - Github user zentol commented on the issue: https://github.com/apache/flink/pull/3361 Could you add a screenshot how it would look like after the changes?
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user nellboy opened a pull request:

          https://github.com/apache/flink/pull/3361

          FLINK-5819 [webui] implements numeric option on metrics graphs

          enables toggling between numeric and graph view for metrics graphs

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/nellboy/flink webui/metrics

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/flink/pull/3361.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #3361


          commit 0d5c883a52b81425441baa3c0b5086196000e393
          Author: paul <nellboy@gmail.com>
          Date: 2017-02-17T12:42:17Z

          FLINK-5819 [webui] implements numeric option on metrics graphs


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user nellboy opened a pull request: https://github.com/apache/flink/pull/3361 FLINK-5819 [webui] implements numeric option on metrics graphs enables toggling between numeric and graph view for metrics graphs You can merge this pull request into a Git repository by running: $ git pull https://github.com/nellboy/flink webui/metrics Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/3361.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3361 commit 0d5c883a52b81425441baa3c0b5086196000e393 Author: paul <nellboy@gmail.com> Date: 2017-02-17T12:42:17Z FLINK-5819 [webui] implements numeric option on metrics graphs
          Hide
          greghogan Greg Hogan added a comment -

          Some charts were added in FLINK-2730 but had to be removed due to the dependency on an incompatibly licensed library.

          We should consider whether charts are best left to external software using Flink's metrics reporters.

          Show
          greghogan Greg Hogan added a comment - Some charts were added in FLINK-2730 but had to be removed due to the dependency on an incompatibly licensed library. We should consider whether charts are best left to external software using Flink's metrics reporters.

            People

            • Assignee:
              Unassigned
              Reporter:
              paul_nelligan Paul Nelligan
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 48h
                48h
                Remaining:
                Remaining Estimate - 48h
                48h
                Logged:
                Time Spent - Not Specified
                Not Specified

                  Development