Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-5814

flink-dist creates wrong symlink when not used with cleaned before

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.2.0
    • Fix Version/s: 1.3.0, 1.2.1
    • Component/s: Build System
    • Labels:
      None

      Description

      If <flink-dir>/build-target already exists, 'mvn package' for flink-dist will create a symbolic link inside <flink-dir>/build-target instead of replacing that symlink. This is due to the behaviour of ln -sf for target links that point to directories and may be solved by adding the --no-dereference parameter.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user NicoK opened a pull request:

          https://github.com/apache/flink/pull/3331

          FLINK-5814 fix packaging flink-dist in unclean source directory

          If `<flink-dir>/build-target` already existed, running `mvn package` for
          flink-dist would create a symbolic link inside `<flink-dir>/build-target`
          instead of replacing that symlink. This commit fixes this behaviour of `ln -sf`
          by adding the `--no-dereference` parameter.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/NicoK/flink flink-5814

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/flink/pull/3331.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #3331


          commit 032209e43c5f6b9641053d3317561646ba0b4f7f
          Author: Nico Kruber <nico@data-artisans.com>
          Date: 2017-02-15T14:50:45Z

          FLINK-5814 fix packaging flink-dist in unclean source directory

          If "<flink-dir>/build-target" already existed, running 'mvn package' for
          flink-dist would create a symbolic link inside "<flink-dir>/build-target"
          instead of replacing that symlink. This commit fixes this behaviour of 'ln -sf'
          by adding the --no-dereference parameter.


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user NicoK opened a pull request: https://github.com/apache/flink/pull/3331 FLINK-5814 fix packaging flink-dist in unclean source directory If `<flink-dir>/build-target` already existed, running `mvn package` for flink-dist would create a symbolic link inside `<flink-dir>/build-target` instead of replacing that symlink. This commit fixes this behaviour of `ln -sf` by adding the `--no-dereference` parameter. You can merge this pull request into a Git repository by running: $ git pull https://github.com/NicoK/flink flink-5814 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/3331.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3331 commit 032209e43c5f6b9641053d3317561646ba0b4f7f Author: Nico Kruber <nico@data-artisans.com> Date: 2017-02-15T14:50:45Z FLINK-5814 fix packaging flink-dist in unclean source directory If "<flink-dir>/build-target" already existed, running 'mvn package' for flink-dist would create a symbolic link inside "<flink-dir>/build-target" instead of replacing that symlink. This commit fixes this behaviour of 'ln -sf' by adding the --no-dereference parameter.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user StephanEwen commented on the issue:

          https://github.com/apache/flink/pull/3331

          +1 merging this...

          Show
          githubbot ASF GitHub Bot added a comment - Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3331 +1 merging this...
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/flink/pull/3331

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3331
          Hide
          StephanEwen Stephan Ewen added a comment -

          Fixed in

          • 1.2.1 via 6114c5b01d60d37efdd7db47bf9378f8dea4385c
          • 1.3.0 via 2ec2abfae58102af2d29ac65ac907f114ade4839
          Show
          StephanEwen Stephan Ewen added a comment - Fixed in 1.2.1 via 6114c5b01d60d37efdd7db47bf9378f8dea4385c 1.3.0 via 2ec2abfae58102af2d29ac65ac907f114ade4839

            People

            • Assignee:
              NicoK Nico Kruber
              Reporter:
              NicoK Nico Kruber
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development