Details

    • Type: Bug
    • Status: Closed
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 1.2.0, 1.3.0
    • Fix Version/s: 1.3.0
    • Component/s: Tests
    • Labels:
      None

      Description

      The YarnClusterDescriptorTest is expecting in some test cases an Exception but does not fail if the exception is not thrown. Moreover it prints the stack trace of the expected exception.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user tillrohrmann opened a pull request:

          https://github.com/apache/flink/pull/3326

          FLINK-5811 [tests] Harden YarnClusterDescriptorTest

          Add fail call after method which is supposed to fail. Remove stack trace printing
          to stdout.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/tillrohrmann/flink FLINK-5811

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/flink/pull/3326.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #3326


          commit 245d28a825782044e1cea3c86240a326e98a5711
          Author: Till Rohrmann <trohrmann@apache.org>
          Date: 2017-02-15T16:51:02Z

          FLINK-5811 [tests] Harden YarnClusterDescriptorTest

          Add fail call after method which is supposed to fail. Remove stack trace printing
          to stdout.


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/3326 FLINK-5811 [tests] Harden YarnClusterDescriptorTest Add fail call after method which is supposed to fail. Remove stack trace printing to stdout. You can merge this pull request into a Git repository by running: $ git pull https://github.com/tillrohrmann/flink FLINK-5811 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/3326.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3326 commit 245d28a825782044e1cea3c86240a326e98a5711 Author: Till Rohrmann <trohrmann@apache.org> Date: 2017-02-15T16:51:02Z FLINK-5811 [tests] Harden YarnClusterDescriptorTest Add fail call after method which is supposed to fail. Remove stack trace printing to stdout.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user StephanEwen commented on the issue:

          https://github.com/apache/flink/pull/3326

          I think this looks good!

          Show
          githubbot ASF GitHub Bot added a comment - Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3326 I think this looks good!
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user tillrohrmann commented on the issue:

          https://github.com/apache/flink/pull/3326

          Thanks for your review @StephanEwen. Merging this PR.

          Show
          githubbot ASF GitHub Bot added a comment - Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/3326 Thanks for your review @StephanEwen. Merging this PR.
          Hide
          till.rohrmann Till Rohrmann added a comment -

          Fixed via 494edb041b5e8474c84eed563e9dfa4406240bb5

          Show
          till.rohrmann Till Rohrmann added a comment - Fixed via 494edb041b5e8474c84eed563e9dfa4406240bb5
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/flink/pull/3326

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3326

            People

            • Assignee:
              till.rohrmann Till Rohrmann
              Reporter:
              till.rohrmann Till Rohrmann
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development