Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.3.0
    • Fix Version/s: 1.3.0
    • Labels:
      None

      Description

      Currently the RPCService interface provides a scheduleRunnable method to schedule Runnables. I would like to generalize this functionality by letting the RPCService provide a ScheduledExecutorService to the user. That way other components which require such an executor service could simply use the one provided by the RPCService.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user tillrohrmann opened a pull request:

          https://github.com/apache/flink/pull/3310

          FLINK-5798 [rpc] Let the RpcService provide a ScheduledExecutorService

          This PR adds the getScheduledExecutorService method to the RpcService interface. So
          henceforth all RpcService implementations have to provide a ScheduledExecutorService
          implementation.

          Currently, we only support the AkkaRpcService. The AkkaRpcService returns a
          ScheduledExecutorService proxy which forwards the schedule calls to the ActorSystem's
          internal scheduler.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/tillrohrmann/flink rpcAddScheduledExecutorService

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/flink/pull/3310.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #3310


          commit 639edf235ffee924e0fba56313cb51f825e3a46d
          Author: Till Rohrmann <trohrmann@apache.org>
          Date: 2017-02-14T15:50:43Z

          FLINK-5798 [rpc] Let the RpcService provide a ScheduledExecutorService

          This PR adds the getScheduledExecutorService method to the RpcService interface. So
          henceforth all RpcService implementations have to provide a ScheduledExecutorService
          implementation.

          Currently, we only support the AkkaRpcService. The AkkaRpcService returns a
          ScheduledExecutorService proxy which forwards the schedule calls to the ActorSystem's
          internal scheduler.


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/3310 FLINK-5798 [rpc] Let the RpcService provide a ScheduledExecutorService This PR adds the getScheduledExecutorService method to the RpcService interface. So henceforth all RpcService implementations have to provide a ScheduledExecutorService implementation. Currently, we only support the AkkaRpcService. The AkkaRpcService returns a ScheduledExecutorService proxy which forwards the schedule calls to the ActorSystem's internal scheduler. You can merge this pull request into a Git repository by running: $ git pull https://github.com/tillrohrmann/flink rpcAddScheduledExecutorService Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/3310.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3310 commit 639edf235ffee924e0fba56313cb51f825e3a46d Author: Till Rohrmann <trohrmann@apache.org> Date: 2017-02-14T15:50:43Z FLINK-5798 [rpc] Let the RpcService provide a ScheduledExecutorService This PR adds the getScheduledExecutorService method to the RpcService interface. So henceforth all RpcService implementations have to provide a ScheduledExecutorService implementation. Currently, we only support the AkkaRpcService. The AkkaRpcService returns a ScheduledExecutorService proxy which forwards the schedule calls to the ActorSystem's internal scheduler.
          Hide
          zjwang zhijiang added a comment -

          That is good, and the heartbeat manager component can reuse the ScheduledExecutorService in RPCService now.

          Show
          zjwang zhijiang added a comment - That is good, and the heartbeat manager component can reuse the ScheduledExecutorService in RPCService now.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user StephanEwen commented on the issue:

          https://github.com/apache/flink/pull/3310

          Looks very good to me!
          +1 to merge this...

          Show
          githubbot ASF GitHub Bot added a comment - Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3310 Looks very good to me! +1 to merge this...
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user tillrohrmann commented on the issue:

          https://github.com/apache/flink/pull/3310

          Thanks for the review @StephanEwen. Merging the PR.

          Show
          githubbot ASF GitHub Bot added a comment - Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/3310 Thanks for the review @StephanEwen. Merging the PR.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/flink/pull/3310

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3310
          Hide
          till.rohrmann Till Rohrmann added a comment -

          Fixed via ccf458dd4d173b3370257177c2bbd9680baa6511

          Show
          till.rohrmann Till Rohrmann added a comment - Fixed via ccf458dd4d173b3370257177c2bbd9680baa6511

            People

            • Assignee:
              till.rohrmann Till Rohrmann
              Reporter:
              till.rohrmann Till Rohrmann
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development