Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.3.0
    • Fix Version/s: 1.2.0, 1.3.0
    • Component/s: Documentation
    • Labels:
      None

      Description

      running a link checker on the locally-served flink docs yields the following broken links (same for online docs):

      15:21:55	Error: 	"Not Found " (404) at link 0.0.0.0:4000/dev/state (from 0.0.0.0:4000/dev/datastream_api.html)
      15:21:55	Error: 	"Not Found " (404) at link 0.0.0.0:4000/monitoring/best_practices.html (from 0.0.0.0:4000/dev/batch/)
      15:21:55	Error: 	"Not Found " (404) at link 0.0.0.0:4000/api/java/org/apache/flink/table/api/Table.html (from 0.0.0.0:4000/dev/table_api.html)
      15:21:55	Error: 	"Not Found " (404) at link 0.0.0.0:4000/dev/state.html (from 0.0.0.0:4000/ops/state_backends.html)
      15:21:55	Error: 	"Not Found " (404) at link 0.0.0.0:4000/internals/state_backends.html (from 0.0.0.0:4000/internals/stream_checkpointing.html)
      

      FYI: command to replay:
      httrack http://0.0.0.0:4000/ -O "$PWD/flink-docs" --testlinks -%v --depth=9999 --ext-depth=0

        Issue Links

          Activity

          Hide
          uce Ufuk Celebi added a comment -

          Fixed 8368681 (release-1.2), ded7fae (master).

          Show
          uce Ufuk Celebi added a comment - Fixed 8368681 (release-1.2), ded7fae (master).
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/flink/pull/3308

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3308
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user rmetzger commented on the issue:

          https://github.com/apache/flink/pull/3308

          Nice, thank you!

          Show
          githubbot ASF GitHub Bot added a comment - Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/3308 Nice, thank you!
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user uce commented on the issue:

          https://github.com/apache/flink/pull/3308

          Thanks for the PR, I'll merge this.

          Show
          githubbot ASF GitHub Bot added a comment - Github user uce commented on the issue: https://github.com/apache/flink/pull/3308 Thanks for the PR, I'll merge this.
          Hide
          NicoK Nico Kruber added a comment -

          /api/java/org/apache/flink/table/api/Table.html is actually available on the server (javadocs are served separately)

          Show
          NicoK Nico Kruber added a comment - /api/java/org/apache/flink/table/api/Table.html is actually available on the server (javadocs are served separately)
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user NicoK opened a pull request:

          https://github.com/apache/flink/pull/3308

          FLINK-5796 fix some broken links in the docs

          this probably also applies to the release-1.2 docs

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/NicoK/flink flink-5796

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/flink/pull/3308.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #3308


          commit 39410e8e1819f142480daf0ae0d9f8acbd7dcf9d
          Author: Nico Kruber <nico@data-artisans.com>
          Date: 2017-02-14T14:56:11Z

          FLINK-5796 fix some broken links in the docs


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user NicoK opened a pull request: https://github.com/apache/flink/pull/3308 FLINK-5796 fix some broken links in the docs this probably also applies to the release-1.2 docs You can merge this pull request into a Git repository by running: $ git pull https://github.com/NicoK/flink flink-5796 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/3308.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3308 commit 39410e8e1819f142480daf0ae0d9f8acbd7dcf9d Author: Nico Kruber <nico@data-artisans.com> Date: 2017-02-14T14:56:11Z FLINK-5796 fix some broken links in the docs
          Hide
          rmetzger Robert Metzger added a comment -

          Sorry, I don't have time for this right now.

          I think we can integrate this check into the build docs script. This way, we don't need to work on buildbot. (ideally this is put into a separate script that is called from both the build docs script and buildbot) (I can do the call in buildbot)

          Show
          rmetzger Robert Metzger added a comment - Sorry, I don't have time for this right now. I think we can integrate this check into the build docs script. This way, we don't need to work on buildbot. (ideally this is put into a separate script that is called from both the build docs script and buildbot) (I can do the call in buildbot)
          Hide
          uce Ufuk Celebi added a comment -

          Robert Metzger Can we integrate this check with the build bot?

          Show
          uce Ufuk Celebi added a comment - Robert Metzger Can we integrate this check with the build bot?

            People

            • Assignee:
              Unassigned
              Reporter:
              NicoK Nico Kruber
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development