Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-5793

Running slot may not be add to AllocatedMap in SlotPool

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.3.0
    • Component/s: Core
    • Labels:
      None

      Description

      In SlotPool, when a slot is returned by a finished task, it will try to find a pending request mataching it. If found, will give the slot to the request, but not add the slot to AllocatedMap.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user shuai-xu opened a pull request:

          https://github.com/apache/flink/pull/3306

          FLINK-5793 [runtime] fix running slot may not be add to AllocatedMap in SlotPool bug

          This pr is for jira #[5793](https://issues.apache.org/jira/browse/FLINK-5793)

          In SlotPool, when a slot is returned by a finished task, it will try to find a
          pending request mataching it. If found, will give the slot to the request, but
          not add the slot to AllocatedMap.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/shuai-xu/flink jira-5793

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/flink/pull/3306.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #3306


          commit 11fe5ae90bb912f88b86aa84124b7b453177a819
          Author: shuai.xus <shuai.xus@alibaba-inc.com>
          Date: 2017-02-14T06:56:41Z

          FLINK-5793 [runtime] fix running slot may not be add to AllocatedMap in SlotPool bug


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user shuai-xu opened a pull request: https://github.com/apache/flink/pull/3306 FLINK-5793 [runtime] fix running slot may not be add to AllocatedMap in SlotPool bug This pr is for jira # [5793] ( https://issues.apache.org/jira/browse/FLINK-5793 ) In SlotPool, when a slot is returned by a finished task, it will try to find a pending request mataching it. If found, will give the slot to the request, but not add the slot to AllocatedMap. You can merge this pull request into a Git repository by running: $ git pull https://github.com/shuai-xu/flink jira-5793 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/3306.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3306 commit 11fe5ae90bb912f88b86aa84124b7b453177a819 Author: shuai.xus <shuai.xus@alibaba-inc.com> Date: 2017-02-14T06:56:41Z FLINK-5793 [runtime] fix running slot may not be add to AllocatedMap in SlotPool bug
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user StephanEwen commented on the issue:

          https://github.com/apache/flink/pull/3306

          Good fix, thanks.
          Could you add a quick unit test for the bug? That way we can make sure the bug is not accidentally re-introduced by another patch.

          Show
          githubbot ASF GitHub Bot added a comment - Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3306 Good fix, thanks. Could you add a quick unit test for the bug? That way we can make sure the bug is not accidentally re-introduced by another patch.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user shuai-xu commented on the issue:

          https://github.com/apache/flink/pull/3306

          @StephanEwen done, add unittest.

          Show
          githubbot ASF GitHub Bot added a comment - Github user shuai-xu commented on the issue: https://github.com/apache/flink/pull/3306 @StephanEwen done, add unittest.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user StephanEwen commented on the issue:

          https://github.com/apache/flink/pull/3306

          Thanks looks good!

          Merging this...

          Show
          githubbot ASF GitHub Bot added a comment - Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3306 Thanks looks good! Merging this...
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/flink/pull/3306

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3306
          Hide
          StephanEwen Stephan Ewen added a comment -

          Fixed in 33ea78ea37fab819a329b09aa213e61c16252067

          Thank you for the contribution!

          Show
          StephanEwen Stephan Ewen added a comment - Fixed in 33ea78ea37fab819a329b09aa213e61c16252067 Thank you for the contribution!

            People

            • Assignee:
              tiemsn shuai.xu
              Reporter:
              tiemsn shuai.xu
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development