Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-5705

webmonitor's request/response use UTF-8 explicitly

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.3.0, 1.2.1
    • Component/s: Webfrontend
    • Labels:
      None

      Description

      QueryStringDecoder and HttpPostRequestDecoder use UTF-8 defined in flink.

      Response set content-encoding header with utf-8

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user shijinkui opened a pull request:

          https://github.com/apache/flink/pull/3257

          FLINK-5705 [WebMonitor] webmonitor request/response use UTF-8 expli…

          QueryStringDecoder and HttpPostRequestDecoder use UTF-8 defined in flink.
          Response set content-encoding header with utf-8

          • [X] General
          • The pull request references the related JIRA issue ("FLINK-5705 webmonitor request/response use UTF-8 explicitly")
          • The pull request addresses only one issue
          • Each commit in the PR has a meaningful commit message (including the JIRA id)
          • [X] Documentation
          • Documentation has been added for new functionality
          • Old documentation affected by the pull request has been updated
          • JavaDoc for public methods has been added
          • [X] Tests & Build
          • Functionality added by the pull request is covered by tests
          • `mvn clean verify` has been executed successfully locally or a Travis build has passed

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/shijinkui/flink FLINK-5705

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/flink/pull/3257.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #3257


          commit adff62fe0c750044c265111b3b5b9472ab60cb08
          Author: shijinkui <shijinkui@huawei.com>
          Date: 2017-02-03T09:26:18Z

          FLINK-5705 [WebMonitor] webmonitor request/response use UTF-8 explicitly


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user shijinkui opened a pull request: https://github.com/apache/flink/pull/3257 FLINK-5705 [WebMonitor] webmonitor request/response use UTF-8 expli… QueryStringDecoder and HttpPostRequestDecoder use UTF-8 defined in flink. Response set content-encoding header with utf-8 [X] General The pull request references the related JIRA issue (" FLINK-5705 webmonitor request/response use UTF-8 explicitly") The pull request addresses only one issue Each commit in the PR has a meaningful commit message (including the JIRA id) [X] Documentation Documentation has been added for new functionality Old documentation affected by the pull request has been updated JavaDoc for public methods has been added [X] Tests & Build Functionality added by the pull request is covered by tests `mvn clean verify` has been executed successfully locally or a Travis build has passed You can merge this pull request into a Git repository by running: $ git pull https://github.com/shijinkui/flink FLINK-5705 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/3257.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3257 commit adff62fe0c750044c265111b3b5b9472ab60cb08 Author: shijinkui <shijinkui@huawei.com> Date: 2017-02-03T09:26:18Z FLINK-5705 [WebMonitor] webmonitor request/response use UTF-8 explicitly
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user StephanEwen commented on the issue:

          https://github.com/apache/flink/pull/3257

          The fix looks good, thanks!
          Merging this...

          Show
          githubbot ASF GitHub Bot added a comment - Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3257 The fix looks good, thanks! Merging this...
          Hide
          StephanEwen Stephan Ewen added a comment -

          Fixed in

          • 1.2.1 via d3f2fe2625171f89404e1b90fa8c9493f5403b3a
          • 1.3.0 via f24514339c78d809a28731fa18e8df638b382e3b
          Show
          StephanEwen Stephan Ewen added a comment - Fixed in 1.2.1 via d3f2fe2625171f89404e1b90fa8c9493f5403b3a 1.3.0 via f24514339c78d809a28731fa18e8df638b382e3b
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/flink/pull/3257

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3257

            People

            • Assignee:
              shijinkui shijinkui
              Reporter:
              shijinkui shijinkui
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development