Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-5644

Task#lastCheckpointSize metric broken

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.2.0, 1.3.0
    • Fix Version/s: 1.3.0, 1.2.1
    • Component/s: Metrics, Streaming
    • Labels:
      None

      Description

      The lastCheckpointSIze metric was broken when we introduced the key-groups. I couldn't find an easy way to fix the metric, as such i propose to remove it.

        Issue Links

          Activity

          Hide
          StephanEwen Stephan Ewen added a comment -

          Fixed in

          • 1.2.1 via 3e59d838fe7554c3431e366ad8305aa2d0585bde
          • 1.3.0 via f3930510c6f54a23f532b8f79aed16ee140e3ce5
          Show
          StephanEwen Stephan Ewen added a comment - Fixed in 1.2.1 via 3e59d838fe7554c3431e366ad8305aa2d0585bde 1.3.0 via f3930510c6f54a23f532b8f79aed16ee140e3ce5
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/flink/pull/3214

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3214
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user StephanEwen commented on the issue:

          https://github.com/apache/flink/pull/3214

          Ah, good, that seems the better way to do it, agreed.

          Merging this for `master` and `release-1.2`-...

          Show
          githubbot ASF GitHub Bot added a comment - Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3214 Ah, good, that seems the better way to do it, agreed. Merging this for `master` and `release-1.2`-...
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user zentol commented on the issue:

          https://github.com/apache/flink/pull/3214

          Everything that the `CheckpointStatsTracker` tracks is also exposed as a metric on the JM.

          Show
          githubbot ASF GitHub Bot added a comment - Github user zentol commented on the issue: https://github.com/apache/flink/pull/3214 Everything that the `CheckpointStatsTracker` tracks is also exposed as a metric on the JM.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user StephanEwen commented on the issue:

          https://github.com/apache/flink/pull/3214

          Are there alternative checkpoint metrics available?

          Show
          githubbot ASF GitHub Bot added a comment - Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3214 Are there alternative checkpoint metrics available?
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user zentol opened a pull request:

          https://github.com/apache/flink/pull/3214

          FLINK-5644 Remove metric: Task#lastCheckpointSize

          This PR removes the lastCheckpointSize metric that was broken when the key-groups were introduced. I couldn't find an easy way to fix it instead.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/zentol/flink 5644_metric_chsize

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/flink/pull/3214.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #3214



          Show
          githubbot ASF GitHub Bot added a comment - GitHub user zentol opened a pull request: https://github.com/apache/flink/pull/3214 FLINK-5644 Remove metric: Task#lastCheckpointSize This PR removes the lastCheckpointSize metric that was broken when the key-groups were introduced. I couldn't find an easy way to fix it instead. You can merge this pull request into a Git repository by running: $ git pull https://github.com/zentol/flink 5644_metric_chsize Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/3214.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3214

            People

            • Assignee:
              Zentol Chesnay Schepler
              Reporter:
              Zentol Chesnay Schepler
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development