Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-5637

Default Flink configuration contains whitespace characters, causing parser WARNings

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.2.0, 1.3.0
    • Fix Version/s: 1.2.0, 1.3.0
    • Component/s: None
    • Labels:

      Description

      2017-01-25 09:45:30,670 WARN  org.apache.flink.configuration.GlobalConfiguration            - Error while trying to split key and value in configuration file /yarn/nm/usercache/robert/appcache/application_1485249546281_0018/container_1485249546281_0018_01_000001/flink-conf.yaml:  
      

      The whitespace is currently in line 67:

      #==============================================================================
       
      # The address under which the web-based runtime monitor listens.
      

      I think we should add a test to the GlobalConfigurationTest that ensures the configuration file we are shipping doesn't produce any WARNings by default.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user rmetzger opened a pull request:

          https://github.com/apache/flink/pull/3216

          FLINK-5637 Avoid warning while parsing YAML configuration files

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/rmetzger/flink flink5637

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/flink/pull/3216.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #3216


          commit 81cf4859d87c9912964d60e0faf05ef5c3abb620
          Author: Robert Metzger <rmetzger@apache.org>
          Date: 2017-01-25T15:31:11Z

          FLINK-5637 Avoid warning while parsing YAML configuration files


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user rmetzger opened a pull request: https://github.com/apache/flink/pull/3216 FLINK-5637 Avoid warning while parsing YAML configuration files You can merge this pull request into a Git repository by running: $ git pull https://github.com/rmetzger/flink flink5637 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/3216.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3216 commit 81cf4859d87c9912964d60e0faf05ef5c3abb620 Author: Robert Metzger <rmetzger@apache.org> Date: 2017-01-25T15:31:11Z FLINK-5637 Avoid warning while parsing YAML configuration files
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user aljoscha commented on the issue:

          https://github.com/apache/flink/pull/3216

          Looks good, though we don't really test whether it silently ignores the empty lines, do we?

          Show
          githubbot ASF GitHub Bot added a comment - Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/3216 Looks good, though we don't really test whether it silently ignores the empty lines, do we?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user rmetzger commented on the issue:

          https://github.com/apache/flink/pull/3216

          Yes. But I think it would be an overkill to add a test to ensure a certain log level.

          I'm going to merge the change now.

          Show
          githubbot ASF GitHub Bot added a comment - Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/3216 Yes. But I think it would be an overkill to add a test to ensure a certain log level. I'm going to merge the change now.
          Show
          rmetzger Robert Metzger added a comment - Fix for 1.2: http://git-wip-us.apache.org/repos/asf/flink/commit/f2240eb9 Fix for 1.3: http://git-wip-us.apache.org/repos/asf/flink/commit/54d3e266
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user rmetzger closed the pull request at:

          https://github.com/apache/flink/pull/3216

          Show
          githubbot ASF GitHub Bot added a comment - Github user rmetzger closed the pull request at: https://github.com/apache/flink/pull/3216

            People

            • Assignee:
              rmetzger Robert Metzger
              Reporter:
              rmetzger Robert Metzger
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development