Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-5617

Check new public APIs in 1.2 release

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.2.0
    • Fix Version/s: 1.2.0, 1.3.0
    • Component/s: Build System
    • Labels:
      None

      Description

      Before releasing Flink 1.2.0, I would like to quickly review which new public methods we are supporting in future releases.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user rmetzger opened a pull request:

          https://github.com/apache/flink/pull/3195

          FLINK-5617 API stability check for Flink 1.2

          With this PR, I'm marking some of the new methods in Flink 1.2 as public evolving / internal, instead of public.

          There are the reports for the covered modules:
          http://people.apache.org/~rmetzger/rel-1.2-japicmp/

          @aljoscha and @kl0u: Are the `fold()` and `reduce()` methods intentionally in the `@Public` scope? http://people.apache.org/~rmetzger/rel-1.2-japicmp/flink-streaming-java.html

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/rmetzger/flink flink5617

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/flink/pull/3195.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #3195


          commit 12d9d631455af2c4b6af1024a8865b534f4db9c8
          Author: Robert Metzger <rmetzger@apache.org>
          Date: 2017-01-23T13:31:27Z

          FLINK-5617 Change reference version for API stability checks to 1.1.4

          commit f7323c2e72e24da3a55fd70d6d27ae33026ecc86
          Author: Robert Metzger <rmetzger@apache.org>
          Date: 2017-01-23T15:28:48Z

          FLINK-5617 Mark some methods as PublicEvolving or Internal


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user rmetzger opened a pull request: https://github.com/apache/flink/pull/3195 FLINK-5617 API stability check for Flink 1.2 With this PR, I'm marking some of the new methods in Flink 1.2 as public evolving / internal, instead of public. There are the reports for the covered modules: http://people.apache.org/~rmetzger/rel-1.2-japicmp/ @aljoscha and @kl0u: Are the `fold()` and `reduce()` methods intentionally in the `@Public` scope? http://people.apache.org/~rmetzger/rel-1.2-japicmp/flink-streaming-java.html You can merge this pull request into a Git repository by running: $ git pull https://github.com/rmetzger/flink flink5617 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/3195.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3195 commit 12d9d631455af2c4b6af1024a8865b534f4db9c8 Author: Robert Metzger <rmetzger@apache.org> Date: 2017-01-23T13:31:27Z FLINK-5617 Change reference version for API stability checks to 1.1.4 commit f7323c2e72e24da3a55fd70d6d27ae33026ecc86 Author: Robert Metzger <rmetzger@apache.org> Date: 2017-01-23T15:28:48Z FLINK-5617 Mark some methods as PublicEvolving or Internal
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user aljoscha commented on the issue:

          https://github.com/apache/flink/pull/3195

          @rmetzger I think they should be `@PublicEvolging`, can you change it in this PR?

          Show
          githubbot ASF GitHub Bot added a comment - Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/3195 @rmetzger I think they should be `@PublicEvolging`, can you change it in this PR?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user rmetzger commented on the issue:

          https://github.com/apache/flink/pull/3195

          Yes, I'll mark them as such while merging. Thank you for taking a look.

          Show
          githubbot ASF GitHub Bot added a comment - Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/3195 Yes, I'll mark them as such while merging. Thank you for taking a look.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/flink/pull/3195

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3195
          Show
          rmetzger Robert Metzger added a comment - Merged for 1.2 in http://git-wip-us.apache.org/repos/asf/flink/commit/45de88db and http://git-wip-us.apache.org/repos/asf/flink/commit/908376ba
          Hide
          aljoscha Aljoscha Krettek added a comment -

          Robert Metzger can this be closed?

          Show
          aljoscha Aljoscha Krettek added a comment - Robert Metzger can this be closed?
          Hide
          rmetzger Robert Metzger added a comment -

          Once I've merged it for 1.3, which just happend in this commit: http://git-wip-us.apache.org/repos/asf/flink/commit/20c76a98

          Show
          rmetzger Robert Metzger added a comment - Once I've merged it for 1.3, which just happend in this commit: http://git-wip-us.apache.org/repos/asf/flink/commit/20c76a98

            People

            • Assignee:
              rmetzger Robert Metzger
              Reporter:
              rmetzger Robert Metzger
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development