Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-5612

GlobPathFilter not-serializable exception

    Details

      Description

      A user reported on the mailing list a non-serializable exception when using the GlobFIlePathFilters.

      It appears that the PathMatchers are all created as anonymous inner classes and thus contain a reference to the encapsulating, non-serializable FileSystem class.

      We can fix this by moving the Matcher instantiation into filterPath(...).

      public static void main(String[] args) throws Exception {
      
          final ExecutionEnvironment env =
      ExecutionEnvironment.getExecutionEnvironment();
          final TextInputFormat format = new TextInputFormat(new Path("/temp"));
      
          format.setFilesFilter(new GlobFilePathFilter(
                  Collections.singletonList("**"),
                  Arrays.asList("**/another_file.bin", "**/dataFile1.txt")
          ));
      
          DataSet<String> result = env.readFile(format,"/tmp");
          result.writeAsText("/temp/out");
          env.execute("GlobFilePathFilter-Test");
      
      }
      
      Exception in thread "main" org.apache.flink.optimizer.CompilerException:
      Error translating node 'Data Source "at
      readFile(ExecutionEnvironment.java:520)
      (org.apache.flink.api.java.io.TextInputFormat)" : NONE [[ GlobalProperties
      [partitioning=RANDOM_PARTITIONED] ]] [[ LocalProperties [ordering=null,
      grouped=null, unique=null] ]]': Could not write the user code wrapper class
      org.apache.flink.api.common.operators.util.UserCodeObjectWrapper :
      java.io.NotSerializableException: sun.nio.fs.UnixFileSystem$3
      at
      org.apache.flink.optimizer.plantranslate.JobGraphGenerator.preVisit(JobGraphGenerator.java:381)
      at
      org.apache.flink.optimizer.plantranslate.JobGraphGenerator.preVisit(JobGraphGenerator.java:106)
      at
      org.apache.flink.optimizer.plan.SourcePlanNode.accept(SourcePlanNode.java:86)
      at
      org.apache.flink.optimizer.plan.SingleInputPlanNode.accept(SingleInputPlanNode.java:199)
      at
      org.apache.flink.optimizer.plan.OptimizedPlan.accept(OptimizedPlan.java:128)
      at
      org.apache.flink.optimizer.plantranslate.JobGraphGenerator.compileJobGraph(JobGraphGenerator.java:192)
      at org.apache.flink.client.LocalExecutor.executePlan(LocalExecutor.java:188)
      at
      org.apache.flink.api.java.LocalEnvironment.execute(LocalEnvironment.java:91)
      at com.apsaltis.EventDetectionJob.main(EventDetectionJob.java:75)
      Caused by:
      org.apache.flink.runtime.operators.util.CorruptConfigurationException:
      Could not write the user code wrapper class
      org.apache.flink.api.common.operators.util.UserCodeObjectWrapper :
      java.io.NotSerializableException: sun.nio.fs.UnixFileSystem$3
      at
      org.apache.flink.runtime.operators.util.TaskConfig.setStubWrapper(TaskConfig.java:281)
      at
      org.apache.flink.optimizer.plantranslate.JobGraphGenerator.createDataSourceVertex(JobGraphGenerator.java:888)
      at
      org.apache.flink.optimizer.plantranslate.JobGraphGenerator.preVisit(JobGraphGenerator.java:281)
      ... 8 more
      Caused by: java.io.NotSerializableException: sun.nio.fs.UnixFileSystem$3
      at java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1184)
      at java.io.ObjectOutputStream.writeObject(ObjectOutputStream.java:348)
      at java.util.ArrayList.writeObject(ArrayList.java:747)
      at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
      at
      sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
      at
      sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
      at java.lang.reflect.Method.invoke(Method.java:483)
      at java.io.ObjectStreamClass.invokeWriteObject(ObjectStreamClass.java:988)
      at java.io.ObjectOutputStream.writeSerialData(ObjectOutputStream.java:1496)
      at
      java.io.ObjectOutputStream.writeOrdinaryObject(ObjectOutputStream.java:1432)
      at java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1178)
      at
      java.io.ObjectOutputStream.defaultWriteFields(ObjectOutputStream.java:1548)
      at java.io.ObjectOutputStream.writeSerialData(ObjectOutputStream.java:1509)
      at
      java.io.ObjectOutputStream.writeOrdinaryObject(ObjectOutputStream.java:1432)
      at java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1178)
      at
      java.io.ObjectOutputStream.defaultWriteFields(ObjectOutputStream.java:1548)
      at java.io.ObjectOutputStream.writeSerialData(ObjectOutputStream.java:1509)
      at
      java.io.ObjectOutputStream.writeOrdinaryObject(ObjectOutputStream.java:1432)
      at java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1178)
      at
      java.io.ObjectOutputStream.defaultWriteFields(ObjectOutputStream.java:1548)
      at java.io.ObjectOutputStream.writeSerialData(ObjectOutputStream.java:1509)
      at
      java.io.ObjectOutputStream.writeOrdinaryObject(ObjectOutputStream.java:1432)
      at java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1178)
      at java.io.ObjectOutputStream.writeObject(ObjectOutputStream.java:348)
      at
      org.apache.flink.util.InstantiationUtil.serializeObject(InstantiationUtil.java:317)
      at
      org.apache.flink.util.InstantiationUtil.writeObjectToConfig(InstantiationUtil.java:254)
      at
      org.apache.flink.runtime.operators.util.TaskConfig.setStubWrapper(TaskConfig.java:279)
      ... 10 more
      

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user mushketyk closed the pull request at:

          https://github.com/apache/flink/pull/3206

          Show
          githubbot ASF GitHub Bot added a comment - Github user mushketyk closed the pull request at: https://github.com/apache/flink/pull/3206
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user mushketyk commented on the issue:

          https://github.com/apache/flink/pull/3206

          @zentol Sure. Thank you for merging this!

          Show
          githubbot ASF GitHub Bot added a comment - Github user mushketyk commented on the issue: https://github.com/apache/flink/pull/3206 @zentol Sure. Thank you for merging this!
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user zentol commented on the issue:

          https://github.com/apache/flink/pull/3206

          @mushketyk The changes have been merged, could you close this PR?

          Show
          githubbot ASF GitHub Bot added a comment - Github user zentol commented on the issue: https://github.com/apache/flink/pull/3206 @mushketyk The changes have been merged, could you close this PR?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user mushketyk commented on the issue:

          https://github.com/apache/flink/pull/3206

          Thank you @StephanEwen !

          Show
          githubbot ASF GitHub Bot added a comment - Github user mushketyk commented on the issue: https://github.com/apache/flink/pull/3206 Thank you @StephanEwen !
          Hide
          StephanEwen Stephan Ewen added a comment -

          Fixed in

          • 1.2.0 via bb9a95a51678633c2bf6fa5bb6f6219fd9d8409d
          • 1.3.0 via ef96054d18ca1fb35f933fd0c715bb1ecc39b8c9
          Show
          StephanEwen Stephan Ewen added a comment - Fixed in 1.2.0 via bb9a95a51678633c2bf6fa5bb6f6219fd9d8409d 1.3.0 via ef96054d18ca1fb35f933fd0c715bb1ecc39b8c9
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user StephanEwen commented on the issue:

          https://github.com/apache/flink/pull/3206

          Looks good, will merge this and fix the public annotation on the fly..

          Show
          githubbot ASF GitHub Bot added a comment - Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3206 Looks good, will merge this and fix the public annotation on the fly..
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user StephanEwen commented on the issue:

          https://github.com/apache/flink/pull/3206

          @EronWright Agreed, this should be `@Public(Evolving)`.

          Show
          githubbot ASF GitHub Bot added a comment - Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3206 @EronWright Agreed, this should be `@Public(Evolving)`.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user EronWright commented on the issue:

          https://github.com/apache/flink/pull/3206

          Just hit this issue, was about to file an issue. Awesome to see this fixed.

          It is odd to me that `GlobFilePathFilter` is marked `@Internal`.

          Show
          githubbot ASF GitHub Bot added a comment - Github user EronWright commented on the issue: https://github.com/apache/flink/pull/3206 Just hit this issue, was about to file an issue. Awesome to see this fixed. It is odd to me that `GlobFilePathFilter` is marked `@Internal`.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user mushketyk commented on the issue:

          https://github.com/apache/flink/pull/3206

          Hi @StephanEwen, @zentol

          Thank you for helping with this PR.
          I've updated it according to your review.

          Show
          githubbot ASF GitHub Bot added a comment - Github user mushketyk commented on the issue: https://github.com/apache/flink/pull/3206 Hi @StephanEwen, @zentol Thank you for helping with this PR. I've updated it according to your review.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user StephanEwen commented on a diff in the pull request:

          https://github.com/apache/flink/pull/3206#discussion_r98027531

          — Diff: flink-core/src/main/java/org/apache/flink/api/common/io/GlobFilePathFilter.java —
          @@ -52,8 +53,13 @@

          private static final long serialVersionUID = 1L;

          • private final ArrayList<PathMatcher> includeMatchers;
          • private final ArrayList<PathMatcher> excludeMatchers;
            + private final List<String> includePatterns;
            + private final List<String> excludePatterns;
            +
            + // Path matchers are not serializable so we are delaying their
            + // creation until they are used
            + transient private ArrayList<PathMatcher> includeMatchers;
              • End diff –

          Agreed, let's get the style aligned with the rest of the project.

          Show
          githubbot ASF GitHub Bot added a comment - Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/3206#discussion_r98027531 — Diff: flink-core/src/main/java/org/apache/flink/api/common/io/GlobFilePathFilter.java — @@ -52,8 +53,13 @@ private static final long serialVersionUID = 1L; private final ArrayList<PathMatcher> includeMatchers; private final ArrayList<PathMatcher> excludeMatchers; + private final List<String> includePatterns; + private final List<String> excludePatterns; + + // Path matchers are not serializable so we are delaying their + // creation until they are used + transient private ArrayList<PathMatcher> includeMatchers; End diff – Agreed, let's get the style aligned with the rest of the project.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user StephanEwen commented on a diff in the pull request:

          https://github.com/apache/flink/pull/3206#discussion_r98027416

          — Diff: flink-core/src/test/java/org/apache/flink/api/common/io/GlobFilePathFilterTest.java —
          @@ -138,4 +140,27 @@ public void doubleStarPattern()

          { assertFalse(matcher.filterPath(new Path("a/b"))); assertFalse(matcher.filterPath(new Path("a/b/c"))); }

          +
          + @Test(expected = NullPointerException.class)
          + public void testIncluePatternIsNull()

          { + new GlobFilePathFilter( + null, + Collections.<String>emptyList()); + }

          +
          + @Test(expected = NullPointerException.class)
          + public void testExcludePatternIsNull()

          { + new GlobFilePathFilter( + Collections.singletonList("**"), + null); + }

          +
          + @Test
          + public void testGlobFilterSerializable() throws IOException {
          + GlobFilePathFilter matcher = new GlobFilePathFilter(
          + Collections.singletonList("**"),
          + Collections.<String>emptyList());
          +
          + CommonTestUtils.createCopySerializable(matcher);
          — End diff –

          A doof addition here would be to check that after the serialization, the filter behaves in the same way as before.

          Show
          githubbot ASF GitHub Bot added a comment - Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/3206#discussion_r98027416 — Diff: flink-core/src/test/java/org/apache/flink/api/common/io/GlobFilePathFilterTest.java — @@ -138,4 +140,27 @@ public void doubleStarPattern() { assertFalse(matcher.filterPath(new Path("a/b"))); assertFalse(matcher.filterPath(new Path("a/b/c"))); } + + @Test(expected = NullPointerException.class) + public void testIncluePatternIsNull() { + new GlobFilePathFilter( + null, + Collections.<String>emptyList()); + } + + @Test(expected = NullPointerException.class) + public void testExcludePatternIsNull() { + new GlobFilePathFilter( + Collections.singletonList("**"), + null); + } + + @Test + public void testGlobFilterSerializable() throws IOException { + GlobFilePathFilter matcher = new GlobFilePathFilter( + Collections.singletonList("**"), + Collections.<String>emptyList()); + + CommonTestUtils.createCopySerializable(matcher); — End diff – A doof addition here would be to check that after the serialization, the filter behaves in the same way as before.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user zentol commented on the issue:

          https://github.com/apache/flink/pull/3206

          +1 to merge.

          Show
          githubbot ASF GitHub Bot added a comment - Github user zentol commented on the issue: https://github.com/apache/flink/pull/3206 +1 to merge.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user zentol commented on a diff in the pull request:

          https://github.com/apache/flink/pull/3206#discussion_r97969620

          — Diff: flink-core/src/main/java/org/apache/flink/api/common/io/GlobFilePathFilter.java —
          @@ -52,8 +53,13 @@

          private static final long serialVersionUID = 1L;

          • private final ArrayList<PathMatcher> includeMatchers;
          • private final ArrayList<PathMatcher> excludeMatchers;
            + private final List<String> includePatterns;
            + private final List<String> excludePatterns;
            +
            + // Path matchers are not serializable so we are delaying their
            + // creation until they are used
            + transient private ArrayList<PathMatcher> includeMatchers;
              • End diff –

          Now this is nitpicky, but i think the convention is that transient comes after private.

          Show
          githubbot ASF GitHub Bot added a comment - Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3206#discussion_r97969620 — Diff: flink-core/src/main/java/org/apache/flink/api/common/io/GlobFilePathFilter.java — @@ -52,8 +53,13 @@ private static final long serialVersionUID = 1L; private final ArrayList<PathMatcher> includeMatchers; private final ArrayList<PathMatcher> excludeMatchers; + private final List<String> includePatterns; + private final List<String> excludePatterns; + + // Path matchers are not serializable so we are delaying their + // creation until they are used + transient private ArrayList<PathMatcher> includeMatchers; End diff – Now this is nitpicky, but i think the convention is that transient comes after private.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user mushketyk commented on the issue:

          https://github.com/apache/flink/pull/3206

          Hi @StephanEwen, @zentol

          Thank you for your comments. I've update the PR accordingly.

          Show
          githubbot ASF GitHub Bot added a comment - Github user mushketyk commented on the issue: https://github.com/apache/flink/pull/3206 Hi @StephanEwen, @zentol Thank you for your comments. I've update the PR accordingly.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user StephanEwen commented on a diff in the pull request:

          https://github.com/apache/flink/pull/3206#discussion_r97802390

          — Diff: flink-core/src/main/java/org/apache/flink/api/common/io/GlobFilePathFilter.java —
          @@ -52,8 +53,13 @@

          private static final long serialVersionUID = 1L;

          • private final ArrayList<PathMatcher> includeMatchers;
          • private final ArrayList<PathMatcher> excludeMatchers;
            + private final List<String> includePatterns;
            + private final List<String> excludePatterns;
            +
            + // Path matchers are not serializable so we are delaying their
            + // creation until they are used
            + private ArrayList<PathMatcher> includeMatchers;
              • End diff –

          +1 to make them transient - this documents and enforces that

          Show
          githubbot ASF GitHub Bot added a comment - Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/3206#discussion_r97802390 — Diff: flink-core/src/main/java/org/apache/flink/api/common/io/GlobFilePathFilter.java — @@ -52,8 +53,13 @@ private static final long serialVersionUID = 1L; private final ArrayList<PathMatcher> includeMatchers; private final ArrayList<PathMatcher> excludeMatchers; + private final List<String> includePatterns; + private final List<String> excludePatterns; + + // Path matchers are not serializable so we are delaying their + // creation until they are used + private ArrayList<PathMatcher> includeMatchers; End diff – +1 to make them transient - this documents and enforces that
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user StephanEwen commented on a diff in the pull request:

          https://github.com/apache/flink/pull/3206#discussion_r97768800

          — Diff: flink-core/src/test/java/org/apache/flink/api/common/io/GlobFilePathFilterTest.java —
          @@ -138,4 +141,30 @@ public void doubleStarPattern()

          { assertFalse(matcher.filterPath(new Path("a/b"))); assertFalse(matcher.filterPath(new Path("a/b/c"))); }

          +
          + @Test(expected = NullPointerException.class)
          + public void testIncluePatternIsNull()

          { + new GlobFilePathFilter( + null, + Collections.<String>emptyList()); + }

          +
          + @Test(expected = NullPointerException.class)
          + public void testExcludePatternIsNull()

          { + new GlobFilePathFilter( + Collections.singletonList("**"), + null); + }

          +
          + @Test
          + public void testGlobFilterSerializable() throws IOException {
          — End diff –

          How about using `CommonTestUtils.createCopySerializable()` here? That you can validate also that the serialized copy behaves valid.

          Show
          githubbot ASF GitHub Bot added a comment - Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/3206#discussion_r97768800 — Diff: flink-core/src/test/java/org/apache/flink/api/common/io/GlobFilePathFilterTest.java — @@ -138,4 +141,30 @@ public void doubleStarPattern() { assertFalse(matcher.filterPath(new Path("a/b"))); assertFalse(matcher.filterPath(new Path("a/b/c"))); } + + @Test(expected = NullPointerException.class) + public void testIncluePatternIsNull() { + new GlobFilePathFilter( + null, + Collections.<String>emptyList()); + } + + @Test(expected = NullPointerException.class) + public void testExcludePatternIsNull() { + new GlobFilePathFilter( + Collections.singletonList("**"), + null); + } + + @Test + public void testGlobFilterSerializable() throws IOException { — End diff – How about using `CommonTestUtils.createCopySerializable()` here? That you can validate also that the serialized copy behaves valid.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user zentol commented on a diff in the pull request:

          https://github.com/apache/flink/pull/3206#discussion_r97746636

          — Diff: flink-core/src/main/java/org/apache/flink/api/common/io/GlobFilePathFilter.java —
          @@ -69,8 +75,8 @@ public GlobFilePathFilter() {

          • @param excludePatterns glob patterns for files to exclude
            */
            public GlobFilePathFilter(List<String> includePatterns, List<String> excludePatterns) {
          • includeMatchers = buildPatterns(includePatterns);
          • excludeMatchers = buildPatterns(excludePatterns);
            + this.includePatterns = Preconditions.checkNotNull(includePatterns);
            + this.excludePatterns = Preconditions.checkNotNull(excludePatterns) ;
              • End diff –

          spaces before `;` should be removed

          Show
          githubbot ASF GitHub Bot added a comment - Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3206#discussion_r97746636 — Diff: flink-core/src/main/java/org/apache/flink/api/common/io/GlobFilePathFilter.java — @@ -69,8 +75,8 @@ public GlobFilePathFilter() { @param excludePatterns glob patterns for files to exclude */ public GlobFilePathFilter(List<String> includePatterns, List<String> excludePatterns) { includeMatchers = buildPatterns(includePatterns); excludeMatchers = buildPatterns(excludePatterns); + this.includePatterns = Preconditions.checkNotNull(includePatterns); + this.excludePatterns = Preconditions.checkNotNull(excludePatterns) ; End diff – spaces before `;` should be removed
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user zentol commented on a diff in the pull request:

          https://github.com/apache/flink/pull/3206#discussion_r97746573

          — Diff: flink-core/src/main/java/org/apache/flink/api/common/io/GlobFilePathFilter.java —
          @@ -106,12 +112,27 @@ public boolean filterPath(Path filePath)

          { return true; }

          + public ArrayList<PathMatcher> getIncludeMatchers() {
          — End diff –

          these should be private

          Show
          githubbot ASF GitHub Bot added a comment - Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3206#discussion_r97746573 — Diff: flink-core/src/main/java/org/apache/flink/api/common/io/GlobFilePathFilter.java — @@ -106,12 +112,27 @@ public boolean filterPath(Path filePath) { return true; } + public ArrayList<PathMatcher> getIncludeMatchers() { — End diff – these should be private
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user zentol commented on a diff in the pull request:

          https://github.com/apache/flink/pull/3206#discussion_r97746438

          — Diff: flink-core/src/main/java/org/apache/flink/api/common/io/GlobFilePathFilter.java —
          @@ -52,8 +53,13 @@

          private static final long serialVersionUID = 1L;

          • private final ArrayList<PathMatcher> includeMatchers;
          • private final ArrayList<PathMatcher> excludeMatchers;
            + private final List<String> includePatterns;
            + private final List<String> excludePatterns;
            +
            + // Path matchers are not serializable so we are delaying their
            + // creation until they are used
            + private ArrayList<PathMatcher> includeMatchers;
              • End diff –

          these can be transient

          Show
          githubbot ASF GitHub Bot added a comment - Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3206#discussion_r97746438 — Diff: flink-core/src/main/java/org/apache/flink/api/common/io/GlobFilePathFilter.java — @@ -52,8 +53,13 @@ private static final long serialVersionUID = 1L; private final ArrayList<PathMatcher> includeMatchers; private final ArrayList<PathMatcher> excludeMatchers; + private final List<String> includePatterns; + private final List<String> excludePatterns; + + // Path matchers are not serializable so we are delaying their + // creation until they are used + private ArrayList<PathMatcher> includeMatchers; End diff – these can be transient
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user mushketyk opened a pull request:

          https://github.com/apache/flink/pull/3206

          FLINK-5612 Fix GlobPathFilter not-serializable exception

          Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
          If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
          In addition to going through the list, please provide a meaningful description of your changes.

          • [x] General
          • The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
          • The pull request addresses only one issue
          • Each commit in the PR has a meaningful commit message (including the JIRA id)
          • [x] Documentation
          • Documentation has been added for new functionality
          • Old documentation affected by the pull request has been updated
          • JavaDoc for public methods has been added
          • [x] Tests & Build
          • Functionality added by the pull request is covered by tests
          • `mvn clean verify` has been executed successfully locally or a Travis build has passed

          Fixed GlobPathFilter serialization exception. As suggested in the JIRA I've made instantiation of PathMatcher's objects lazy to avoid their serialization.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/mushketyk/flink fix-serialization

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/flink/pull/3206.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #3206


          commit 47ab75792340191a0bbfdc8e9a3b527f819181a3
          Author: Ivan Mushketyk <ivan.mushketik@gmail.com>
          Date: 2017-01-25T09:24:21Z

          FLINK-5612 Fix GlobPathFilter not-serializable exception


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user mushketyk opened a pull request: https://github.com/apache/flink/pull/3206 FLINK-5612 Fix GlobPathFilter not-serializable exception Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration. If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide] ( http://flink.apache.org/how-to-contribute.html ). In addition to going through the list, please provide a meaningful description of your changes. [x] General The pull request references the related JIRA issue (" [FLINK-XXX] Jira title text") The pull request addresses only one issue Each commit in the PR has a meaningful commit message (including the JIRA id) [x] Documentation Documentation has been added for new functionality Old documentation affected by the pull request has been updated JavaDoc for public methods has been added [x] Tests & Build Functionality added by the pull request is covered by tests `mvn clean verify` has been executed successfully locally or a Travis build has passed Fixed GlobPathFilter serialization exception. As suggested in the JIRA I've made instantiation of PathMatcher's objects lazy to avoid their serialization. You can merge this pull request into a Git repository by running: $ git pull https://github.com/mushketyk/flink fix-serialization Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/3206.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3206 commit 47ab75792340191a0bbfdc8e9a3b527f819181a3 Author: Ivan Mushketyk <ivan.mushketik@gmail.com> Date: 2017-01-25T09:24:21Z FLINK-5612 Fix GlobPathFilter not-serializable exception
          Hide
          ivan.mushketyk Ivan Mushketyk added a comment -

          I'll fix it.

          Show
          ivan.mushketyk Ivan Mushketyk added a comment - I'll fix it.

            People

            • Assignee:
              ivan.mushketyk Ivan Mushketyk
              Reporter:
              Zentol Chesnay Schepler
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development