Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-5586

Extend TableProgramsTestBase for object reuse modes

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Implemented
    • Affects Version/s: None
    • Fix Version/s: 1.3.0
    • Component/s: Table API & SQL
    • Labels:
      None

      Description

      We should also test if all runtime operators of the Table API work correctly if object reuse mode is set to true. This should be done for all cluster-based ITCases, not the collection-based ones.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/flink/pull/3339

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3339
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user fhueske commented on the issue:

          https://github.com/apache/flink/pull/3339

          Hi @KurtYoung, FLINK-5955 was resolved by #3465.
          This PR should be good to merge now.

          Show
          githubbot ASF GitHub Bot added a comment - Github user fhueske commented on the issue: https://github.com/apache/flink/pull/3339 Hi @KurtYoung, FLINK-5955 was resolved by #3465. This PR should be good to merge now.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user KurtYoung commented on the issue:

          https://github.com/apache/flink/pull/3339

          Seems like this will effect the new aggregate interface and make the tests failed, will wait for that fix first.

          Show
          githubbot ASF GitHub Bot added a comment - Github user KurtYoung commented on the issue: https://github.com/apache/flink/pull/3339 Seems like this will effect the new aggregate interface and make the tests failed, will wait for that fix first.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user fhueske commented on the issue:

          https://github.com/apache/flink/pull/3339

          I can do it as well.

          Show
          githubbot ASF GitHub Bot added a comment - Github user fhueske commented on the issue: https://github.com/apache/flink/pull/3339 I can do it as well.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user KurtYoung commented on the issue:

          https://github.com/apache/flink/pull/3339

          I don't have merge permission yet, can you help merge this @twalthr ? Thanks.

          Show
          githubbot ASF GitHub Bot added a comment - Github user KurtYoung commented on the issue: https://github.com/apache/flink/pull/3339 I don't have merge permission yet, can you help merge this @twalthr ? Thanks.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user fhueske commented on the issue:

          https://github.com/apache/flink/pull/3339

          The changes look good to me. Thanks @KurtYoung

          Show
          githubbot ASF GitHub Bot added a comment - Github user fhueske commented on the issue: https://github.com/apache/flink/pull/3339 The changes look good to me. Thanks @KurtYoung
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user KurtYoung commented on the issue:

          https://github.com/apache/flink/pull/3339

          hey @fhueske can you take a look at this?

          Show
          githubbot ASF GitHub Bot added a comment - Github user KurtYoung commented on the issue: https://github.com/apache/flink/pull/3339 hey @fhueske can you take a look at this?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user KurtYoung commented on the issue:

          https://github.com/apache/flink/pull/3339

          rebased to the latest master.

          Show
          githubbot ASF GitHub Bot added a comment - Github user KurtYoung commented on the issue: https://github.com/apache/flink/pull/3339 rebased to the latest master.
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user KurtYoung opened a pull request:

          https://github.com/apache/flink/pull/3339

          FLINK-5586 [table] Extend TableProgramsClusterTestBase for object reuse mode

          Make all cluster-based ITCases verified in object reuse mode. This only includes batch table tests now.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/KurtYoung/flink flink-5586

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/flink/pull/3339.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #3339


          commit cef47477601339d374f401439be2001d408c5014
          Author: Kurt Young <ykt836@gmail.com>
          Date: 2017-02-17T09:02:23Z

          FLINK-5586 [table] Extend TableProgramsClusterTestBase for object reuse mode


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user KurtYoung opened a pull request: https://github.com/apache/flink/pull/3339 FLINK-5586 [table] Extend TableProgramsClusterTestBase for object reuse mode Make all cluster-based ITCases verified in object reuse mode. This only includes batch table tests now. You can merge this pull request into a Git repository by running: $ git pull https://github.com/KurtYoung/flink flink-5586 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/3339.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3339 commit cef47477601339d374f401439be2001d408c5014 Author: Kurt Young <ykt836@gmail.com> Date: 2017-02-17T09:02:23Z FLINK-5586 [table] Extend TableProgramsClusterTestBase for object reuse mode
          Hide
          ykt836 Kurt Young added a comment -

          It looks like TableProgramsTestBase is only used in batch mode tests. The streaming table cluster tests are all inherited from StreamingMultipleProgramsTestBase, should we also check the object reuse mode in streaming environment?

          Show
          ykt836 Kurt Young added a comment - It looks like TableProgramsTestBase is only used in batch mode tests. The streaming table cluster tests are all inherited from StreamingMultipleProgramsTestBase , should we also check the object reuse mode in streaming environment?

            People

            • Assignee:
              ykt836 Kurt Young
              Reporter:
              twalthr Timo Walther
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development