Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-5560

Header in checkpoint stats summary misaligned

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.2.0, 1.3.0
    • Component/s: Webfrontend
    • Labels:
      None

      Description

      The checkpoint summary stats table header line is misaligned. The first and second head columns need to be swapped.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user uce opened a pull request:

          https://github.com/apache/flink/pull/3165

          FLINK-5560 [webfrontend] Align table header columns with body

          The checkpoint summary stats table was misaligned. The header listed the state size before the end to end duration whereas the body had end to end duration before the state size. This PR swaps the header columns.

          I've also piggybacked a small hotfix to the reported subtask stats that confused me when I revisted it during this fix. I'll merge this as soon as Travis passes.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/uce/flink 5560-misaligned

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/flink/pull/3165.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #3165


          commit 5ebae2d2db356031981b979db59a7b51fae47395
          Author: Ufuk Celebi <uce@apache.org>
          Date: 2017-01-18T17:31:32Z

          FLINK-5560 [webfrontend] Align table header columns with body

          commit cf7712b08ea675235689185f9625af169a83b343
          Author: Ufuk Celebi <uce@apache.org>
          Date: 2017-01-18T17:32:14Z

          [hotfix] [webfrontend] Rename 'pending' subtask stat to 'pending_or_failed'

          commit 364b4a49be8a48c3e5a65d94885f8856edd71758
          Author: Ufuk Celebi <uce@apache.org>
          Date: 2017-01-18T17:33:17Z

          [webfrontend] Rebuild web frontend


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user uce opened a pull request: https://github.com/apache/flink/pull/3165 FLINK-5560 [webfrontend] Align table header columns with body The checkpoint summary stats table was misaligned. The header listed the state size before the end to end duration whereas the body had end to end duration before the state size. This PR swaps the header columns. I've also piggybacked a small hotfix to the reported subtask stats that confused me when I revisted it during this fix. I'll merge this as soon as Travis passes. You can merge this pull request into a Git repository by running: $ git pull https://github.com/uce/flink 5560-misaligned Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/3165.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3165 commit 5ebae2d2db356031981b979db59a7b51fae47395 Author: Ufuk Celebi <uce@apache.org> Date: 2017-01-18T17:31:32Z FLINK-5560 [webfrontend] Align table header columns with body commit cf7712b08ea675235689185f9625af169a83b343 Author: Ufuk Celebi <uce@apache.org> Date: 2017-01-18T17:32:14Z [hotfix] [webfrontend] Rename 'pending' subtask stat to 'pending_or_failed' commit 364b4a49be8a48c3e5a65d94885f8856edd71758 Author: Ufuk Celebi <uce@apache.org> Date: 2017-01-18T17:33:17Z [webfrontend] Rebuild web frontend
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user rmetzger commented on the issue:

          https://github.com/apache/flink/pull/3165

          +1

          Show
          githubbot ASF GitHub Bot added a comment - Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/3165 +1
          Hide
          uce Ufuk Celebi added a comment -

          Fixed in 772884e (release-1.2), 1be76f6 (master).

          Show
          uce Ufuk Celebi added a comment - Fixed in 772884e (release-1.2), 1be76f6 (master).
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user uce closed the pull request at:

          https://github.com/apache/flink/pull/3165

          Show
          githubbot ASF GitHub Bot added a comment - Github user uce closed the pull request at: https://github.com/apache/flink/pull/3165

            People

            • Assignee:
              uce Ufuk Celebi
              Reporter:
              uce Ufuk Celebi
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development