Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-5829 Bump Calcite version to 1.12 once available
  3. FLINK-5545

Remove FlinkAggregateExpandDistinctAggregatesRule when upgrading to Calcite 1.12

    Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.3.0
    • Fix Version/s: 1.3.0
    • Component/s: Table API & SQL
    • Labels:
      None

      Description

      We copy calcite's AggregateExpandDistinctAggregatesRule to Flink project, and do a quick fix to avoid some bad case mentioned in CALCITE-1558.
      Should drop it and use calcite's AggregateExpandDistinctAggregatesRule when we upgrade to calcite 1.12(above)

        Issue Links

          Activity

          Hide
          twalthr Timo Walther added a comment -

          Zhenghua Gao We updated the Calcite version. Would be great if you could open a PR for this issue or unassign it.

          Show
          twalthr Timo Walther added a comment - Zhenghua Gao We updated the Calcite version. Would be great if you could open a PR for this issue or unassign it.
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user KurtYoung opened a pull request:

          https://github.com/apache/flink/pull/3695

          FLINK-5545 [table] Remove FlinkAggregateExpandDistinctAggregatesRul…

          …e after bumping Calcite to v1.12.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/KurtYoung/flink flink-5545

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/flink/pull/3695.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #3695


          commit 2d8c740852e56cbc54120acea234975771171a66
          Author: Kurt Young <ykt836@gmail.com>
          Date: 2017-04-07T09:46:06Z

          FLINK-5545 [table] Remove FlinkAggregateExpandDistinctAggregatesRule after bumping Calcite to v1.12.


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user KurtYoung opened a pull request: https://github.com/apache/flink/pull/3695 FLINK-5545 [table] Remove FlinkAggregateExpandDistinctAggregatesRul… …e after bumping Calcite to v1.12. You can merge this pull request into a Git repository by running: $ git pull https://github.com/KurtYoung/flink flink-5545 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/3695.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3695 commit 2d8c740852e56cbc54120acea234975771171a66 Author: Kurt Young <ykt836@gmail.com> Date: 2017-04-07T09:46:06Z FLINK-5545 [table] Remove FlinkAggregateExpandDistinctAggregatesRule after bumping Calcite to v1.12.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user fhueske commented on the issue:

          https://github.com/apache/flink/pull/3695

          Thanks @KurtYoung!
          +1 to merge

          Show
          githubbot ASF GitHub Bot added a comment - Github user fhueske commented on the issue: https://github.com/apache/flink/pull/3695 Thanks @KurtYoung! +1 to merge
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user fhueske commented on the issue:

          https://github.com/apache/flink/pull/3695

          merging

          Show
          githubbot ASF GitHub Bot added a comment - Github user fhueske commented on the issue: https://github.com/apache/flink/pull/3695 merging
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/flink/pull/3695

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3695
          Hide
          fhueske Fabian Hueske added a comment -

          Fixed with 0038da41553908a427dd20be75838cccb48c6bcf

          Show
          fhueske Fabian Hueske added a comment - Fixed with 0038da41553908a427dd20be75838cccb48c6bcf

            People

            • Assignee:
              ykt836 Kurt Young
              Reporter:
              docete Zhenghua Gao
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development