Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-5543

customCommandLine tips in CliFrontend

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.3.0
    • Component/s: Client
    • Labels:
      None

      Description

      Tips: DefaultCLI must be added at the end, because getActiveCustomCommandLine(..) will get the active CustomCommandLine in order and DefaultCLI isActive always return true.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user shijinkui opened a pull request:

          https://github.com/apache/flink/pull/3144

          FLINK-5543[Client] customCommandLine tips in CliFrontend

          Only some code annotation in the CliFrontend.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/shijinkui/flink customCommandLine_tips

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/flink/pull/3144.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #3144


          commit 03229a951c3272358a3aa121b8dfa53bca67d217
          Author: shijinkui <shijinkui@huawei.com>
          Date: 2017-01-18T00:32:31Z

          FLINK-5543[Client] customCommandLine tips in CliFrontend


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user shijinkui opened a pull request: https://github.com/apache/flink/pull/3144 FLINK-5543 [Client] customCommandLine tips in CliFrontend Only some code annotation in the CliFrontend. You can merge this pull request into a Git repository by running: $ git pull https://github.com/shijinkui/flink customCommandLine_tips Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/3144.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3144 commit 03229a951c3272358a3aa121b8dfa53bca67d217 Author: shijinkui <shijinkui@huawei.com> Date: 2017-01-18T00:32:31Z FLINK-5543 [Client] customCommandLine tips in CliFrontend
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user StephanEwen commented on the issue:

          https://github.com/apache/flink/pull/3144

          Thanks, looks good, merging this...

          Show
          githubbot ASF GitHub Bot added a comment - Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3144 Thanks, looks good, merging this...
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/flink/pull/3144

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3144
          Hide
          StephanEwen Stephan Ewen added a comment -

          Fixed in cda40a7fe7ca7c5140dc627b077caa29027f113c

          Thank you for the contribution!

          Show
          StephanEwen Stephan Ewen added a comment - Fixed in cda40a7fe7ca7c5140dc627b077caa29027f113c Thank you for the contribution!

            People

            • Assignee:
              shijinkui shijinkui
              Reporter:
              shijinkui shijinkui
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development